From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: "kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: Re: [PATCH 0/8] guestfs: fixes and enhancements
Date: Fri, 8 Mar 2024 07:56:15 -0800 [thread overview]
Message-ID: <CAB=NE6XLKp9=edqEQJzRbegbTrHSPVtwJ=d0ASBT6TyjNLfytA@mail.gmail.com> (raw)
In-Reply-To: <FC402268-E7F3-405D-93D9-35BCC11AEF33@oracle.com>
On Fri, Mar 8, 2024 at 7:46 AM Chuck Lever III <chuck.lever@oracle.com> wrote:
> > On Mar 8, 2024, at 10:44 AM, Luis Chamberlain <mcgrof@kernel.org> wrote:
> > diff --git a/playbooks/roles/gen_nodes/templates/gen_drives.j2 b/playbooks/roles/gen_nodes/templates/gen_drives.j2
> > index 105e2cf03913..874e5b0623b9 100644
> > --- a/playbooks/roles/gen_nodes/templates/gen_drives.j2
> > +++ b/playbooks/roles/gen_nodes/templates/gen_drives.j2
> > @@ -1,3 +1,4 @@
> > +{% import './templates/drives.j2' as drives %}
> > {% if libvirt_extra_storage_drive_ide %}
> > {{ drives.gen_drive_ide(4,
> > kdevops_storage_pool_path,
> > diff --git a/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml b/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml
> > index 9af9831399d2..a5f60858e402 100644
> > --- a/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml
> > +++ b/playbooks/roles/gen_nodes/templates/guestfs_q35.j2.xml
> > @@ -1,4 +1,3 @@
> > -{% import './templates/drives.j2' as drives %}
> > <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
> > <name>{{ hostname }}</name>
> > <memory unit='MiB'>{{ libvirt_mem_mb }}</memory>
>
> That WFM.
FIx pushed, thanks for testing!
Luis
prev parent reply other threads:[~2024-03-08 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 0:03 [PATCH 0/8] guestfs: fixes and enhancements Luis Chamberlain
2024-03-08 0:03 ` [PATCH 1/8] guestfs: use macros for drives for aarch64 Luis Chamberlain
2024-03-08 0:03 ` [PATCH 2/8] bringup: disable ZNS and CXL for guestfs Luis Chamberlain
2024-03-08 0:03 ` [PATCH 3/8] libvirt: move zns, largio and cxl to its own files Luis Chamberlain
2024-03-08 0:03 ` [PATCH 4/8] guestfs: move options to its own file Luis Chamberlain
2024-03-08 0:03 ` [PATCH 5/8] bringup: match default distro to user's distro Luis Chamberlain
2024-03-08 0:03 ` [PATCH 6/8] guestfs: remove explicit tap0 device name Luis Chamberlain
2024-03-08 0:03 ` [PATCH 7/8] destroy_guestfs.sh: remove known ssh key Luis Chamberlain
2024-03-08 0:03 ` [PATCH 8/8] guestfs: verify new line on ssh include directive Luis Chamberlain
2024-03-08 9:55 ` [PATCH 0/8] guestfs: fixes and enhancements Luis Chamberlain
2024-03-08 14:14 ` Chuck Lever III
2024-03-08 14:26 ` Chuck Lever III
2024-03-08 15:44 ` Luis Chamberlain
2024-03-08 15:46 ` Chuck Lever III
2024-03-08 15:56 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB=NE6XLKp9=edqEQJzRbegbTrHSPVtwJ=d0ASBT6TyjNLfytA@mail.gmail.com' \
--to=mcgrof@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).