From: Chuck Lever III <chuck.lever@oracle.com>
To: Scott Mayhew <smayhew@redhat.com>
Cc: "kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: Re: [PATCH] gen_nodes: fix breakage from "Split ltp set-up from gen_nodes"
Date: Sat, 20 Apr 2024 14:47:55 +0000 [thread overview]
Message-ID: <B7F3C8C8-5B68-4342-815D-7A37B6D132FB@oracle.com> (raw)
In-Reply-To: <20240420094142.2498672-1-smayhew@redhat.com>
> On Apr 20, 2024, at 5:41 AM, Scott Mayhew <smayhew@redhat.com> wrote:
>
> Commit ee1e9d2 inserted a new task in the middle of the "Initialize the
> enabled nodes list for ltp" task, effectively getting rid of that
> task's when clause, causing it to run for non-LTP workloads.
>
> Fixes: ee1e9d2 ("gen_nodes: Split ltp set-up from gen_nodes")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
> playbooks/roles/gen_nodes/tasks/main.yml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml
> index ac9ddd9..06c6a94 100644
> --- a/playbooks/roles/gen_nodes/tasks/main.yml
> +++ b/playbooks/roles/gen_nodes/tasks/main.yml
> @@ -171,6 +171,11 @@
> set_fact:
> is_ltp: True
> ltp_enabled_nodes: "{{ ltp_enabled_test_groups|ansible.builtin.split }}"
> + when:
> + - kdevops_workflows_dedicated_workflow
> + - kdevops_workflow_enable_ltp
> + - ansible_nodes_template.stat.exists
> +
> - name: Generate a kdevops nodes file for the ltp workflow
> tags: hosts
> ansible.builtin.include_role:
> --
> 2.44.0
This is a turd left over from incorrect conflict resolution.
The "Initialize the enabled nodes list for ltp" task needs
to be deleted. I'll push a proper fix. Thanks!
--
Chuck Lever
prev parent reply other threads:[~2024-04-20 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 9:41 [PATCH] gen_nodes: fix breakage from "Split ltp set-up from gen_nodes" Scott Mayhew
2024-04-20 14:47 ` Chuck Lever III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B7F3C8C8-5B68-4342-815D-7A37B6D132FB@oracle.com \
--to=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).