From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, kdevops@lists.linux.dev
Subject: Re: [PATCH RFC 0/4] Simplify guest timezone setting
Date: Sat, 30 Mar 2024 07:11:53 -0400 [thread overview]
Message-ID: <78fe0c25d2466df135db6de01a8979595e851f6e.camel@kernel.org> (raw)
In-Reply-To: <171131869508.1672015.4160924793436750767.stgit@renoir.1015granger.net>
On Sun, 2024-03-24 at 18:22 -0400, Chuck Lever wrote:
> I've been experimenting a bit with a mechanism for setting the
> timezone on locally virtualized target nodes without involving
> Ansible -- because it looks like libvirt can do this for us.
>
> Here are four patches that replace the current Ansible mechanism
> with one for libguestfs and one for vagrant. I've broken this up
> into multiple patches to make review easier, and also make it
> easier to drop one or two of these changes if they prove to be
> controversial or mistaken.
>
> Comments welcome. And so is testing -- I haven't tried this set
> on Debian or Suse yet.
>
> ---
>
> Chuck Lever (4):
> vagrant: Get timezone setting directly from the hypervisor
> guestfs: Use libvirt to set target node timezone
> devconfig: Remove DEVCONFIG_ENABLE_SYSTEMD_TIMESYNCD_COPY_HOST_TIMEZONE
> devconfig: Remove DEVCONFIG_ENABLE_SYSTEMD_TIMESYNCD_TIMEZONE
>
>
> kconfigs/Kconfig.ansible_provisioning | 72 -------------------
> playbooks/roles/devconfig/defaults/main.yml | 3 -
> playbooks/roles/devconfig/tasks/main.yml | 26 -------
> playbooks/roles/gen_nodes/tasks/main.yml | 4 ++
> .../roles/gen_nodes/templates/Vagrantfile.j2 | 1 +
> .../gen_nodes/templates/guestfs_q35.j2.xml | 2 +-
> .../gen_nodes/templates/guestfs_virt.j2.xml | 2 +-
> .../defaults/main.yml | 2 -
> .../install_systemd_timesyncd/tasks/main.yml | 8 ---
> .../tasks/install-deps/debian/main.yml | 8 +++
> .../tasks/install-deps/fedora/main.yml | 5 ++
> .../tasks/install-deps/redhat/main.yml | 10 +++
> .../tasks/install-deps/suse/main.yml | 8 +++
> scripts/systemd-timesync.Makefile | 9 ---
> .../libvirt-qemu/20240202-0001/kdevops.config | 1 -
> .../libvirt-qemu/20240221-0001/kdevops.config | 1 -
> 16 files changed, 38 insertions(+), 124 deletions(-)
>
> --
> Chuck Lever
>
>
I like this. ACK from me.
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2024-03-30 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 22:22 [PATCH RFC 0/4] Simplify guest timezone setting Chuck Lever
2024-03-24 22:22 ` [PATCH RFC 1/4] vagrant: Get timezone setting directly from the hypervisor Chuck Lever
2024-03-24 22:22 ` [PATCH RFC 2/4] guestfs: Use libvirt to set target node timezone Chuck Lever
2024-03-24 22:22 ` [PATCH RFC 3/4] devconfig: Remove DEVCONFIG_ENABLE_SYSTEMD_TIMESYNCD_COPY_HOST_TIMEZONE Chuck Lever
2024-03-24 22:22 ` [PATCH RFC 4/4] devconfig: Remove DEVCONFIG_ENABLE_SYSTEMD_TIMESYNCD_TIMEZONE Chuck Lever
2024-03-26 22:25 ` [PATCH RFC 0/4] Simplify guest timezone setting Luis Chamberlain
2024-03-26 22:29 ` Chuck Lever III
2024-03-26 22:39 ` Chuck Lever III
2024-03-30 11:11 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78fe0c25d2466df135db6de01a8979595e851f6e.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).