From: Chuck Lever III <chuck.lever@oracle.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Chuck Lever <cel@kernel.org>,
"kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: Re: [PATCH v2 4/4] libvirt: Support aarch64 guests
Date: Thu, 7 Mar 2024 14:09:12 +0000 [thread overview]
Message-ID: <57ADD245-06EC-4B1F-A7B0-320609ECFE6F@oracle.com> (raw)
In-Reply-To: <ZejanvGJIOAX8er4@bombadil.infradead.org>
> On Mar 6, 2024, at 4:05 PM, Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Wed, Mar 06, 2024 at 10:03:36AM -0500, Chuck Lever wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>
>>
>> I've added aarch64 support only under guestfs, since I figure
>> Vagrant support in kdevops is not long for this world.
>>
>> - Add a .j2.xml file for building aarch64 nodes
>> - Remove some hard dependencies on the q35 guest definition
>>
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
>> kconfigs/Kconfig.libvirt | 8 +
>> .../roles/gen_nodes/templates/guestfs_virt.j2.xml | 215 ++++++++++++++++++++
>> scripts/gen-nodes.Makefile | 5
>> workflows/linux/Kconfig | 3
>> 4 files changed, 228 insertions(+), 3 deletions(-)
>> create mode 100644 playbooks/roles/gen_nodes/templates/guestfs_virt.j2.xml
>>
>> diff --git a/kconfigs/Kconfig.libvirt b/kconfigs/Kconfig.libvirt
>> index fa39120450fd..6d51a1c26604 100644
>> --- a/kconfigs/Kconfig.libvirt
>> +++ b/kconfigs/Kconfig.libvirt
>> @@ -466,7 +466,8 @@ endif # HAVE_LIBVIRT_PCIE_PASSTHROUGH
>>
>> choice
>> prompt "Machine type to use"
>> - default LIBVIRT_MACHINE_TYPE_Q35
>> + default LIBVIRT_MACHINE_TYPE_Q35 if TARGET_ARCH_X86_64
>> + default LIBVIRT_MACHINE_TYPE_VIRT if TARGET_ARCH_ARM64
>
> Picking q35 when one selected TARGET_ARCH_ARM64 would likely fail at
> bringup, likewise picking LIBVIRT_MACHINE_TYPE_VIRT when one selected
> TARGET_ARCH_X86_64 would fail. So how about just hiding that complexity
> and only presenting q35 as an option if TARGET_ARCH_X86_64 is enabled?
>
> So LIBVIRT_MACHINE_TYPE_Q35 should then depend on TARGET_ARCH_X86_64 and
> LIBVIRT_MACHINE_TYPE_VIRT depend on TARGET_ARCH_ARM64 ?
>
> The above can be kept as is, we'd just make q35 not appear as an option
> if one selected TARGET_ARCH_ARM64 and if one selected TARGET_ARCH_ARM64
> one would not see q35 in the drop down menu as well.
>
> Other than that:
>
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
I split these up a little bit and added your suggestion to
hide inappropriate machine types based on the TARGET_ARCH.
I pushed them but forgot to add your R-b. Apologies!
--
Chuck Lever
prev parent reply other threads:[~2024-03-07 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 15:03 [PATCH v2 0/4] Enable aarch64 with guestfs Chuck Lever
2024-03-06 15:03 ` [PATCH v2 1/4] guestfs: Specify host ISA to virt-builder Chuck Lever
2024-03-06 15:03 ` [PATCH v2 2/4] guestfs: Enable destruction of guests with NVRAM Chuck Lever
2024-03-06 15:03 ` [PATCH v2 3/4] gen_nodes: Instructions for adding a new guestfs architecture Chuck Lever
2024-03-06 15:03 ` [PATCH v2 4/4] libvirt: Support aarch64 guests Chuck Lever
2024-03-06 21:05 ` Luis Chamberlain
2024-03-07 14:09 ` Chuck Lever III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ADD245-06EC-4B1F-A7B0-320609ECFE6F@oracle.com \
--to=chuck.lever@oracle.com \
--cc=cel@kernel.org \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).