kdevops.lists.linux.dev archive mirror
 help / color / mirror / Atom feed

From: Chuck Lever III <chuck.lever@oracle.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: "kdevops@lists.linux.dev" <kdevops@lists.linux.dev>
Subject: scripts/get-distro-default-bridge.sh
Date: Tue, 30 Apr 2024 19:15:21 +0000	[thread overview]
Message-ID: <3E83DEAB-5004-49C4-8852-CCFB1F653FD3@oracle.com> (raw)

Hi Luis-

My mirroring set-up broke somehow on my Vagrant system.
I thought I had tested the gitr workflow mirroring
changes before I pushed them -- maybe I tested it on
one of my guestfs systems.

I copied this change from the many similar changes you did
to the other mirrored git repos:

+config HAVE_MIRROR_GIT
+       bool
+       depends on USE_LIBVIRT_MIRROR
+       default $(shell, scripts/check_mirror_present.sh /mirror/git.git)
+
 config GITR_REPO
        string "The git tool repository to clone"
-       default "https://git.kernel.org/pub/scm/git/git.git"
-       help
+       default DEFAULT_GIT_URL if !HAVE_MIRROR_GIT
+       default $(shell, scripts/append-makefile-vars.sh git:// $(KDEVOPS_DEFAULT_BRIDGE_IP_VAGRANT) /mirror/git.git) if HAVE_MIRROR_GIT && VAGRANT
+       default $(shell, scripts/append-makefile-vars.sh git:// $(KDEVOPS_DEFAULT_BRIDGE_IP_GUESTFS) /mirror/git.git) if HAVE_MIRROR_GIT && GUESTFS
+        help

So KDEVOPS_DEFAULT_BRIDGE_IP_VAGRANT contains

  http://192.168.124.1

which means the GITR_REPO URL looks like this:

  git://http://192.168.124.1/mirror/git.git

Needless to say, ansible.builtin.git does not know what
to do with that URL ;-)

So I'm not quite sure what you intended with commit
a2579089dc70 ("provision: generalize bridge-ip further"),
otherwise I'd just post a fix.

--
Chuck Lever

next             reply	other threads:[~2024-04-30 19:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 19:15 Chuck Lever III [this message]
2024-04-30 19:52 ` scripts/get-distro-default-bridge.sh Luis Chamberlain
2024-04-30 21:12   ` scripts/get-distro-default-bridge.sh Chuck Lever III
2024-04-30 21:18     ` scripts/get-distro-default-bridge.sh Luis Chamberlain
2024-05-01  1:13       ` scripts/get-distro-default-bridge.sh Chuck Lever III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E83DEAB-5004-49C4-8852-CCFB1F653FD3@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=kdevops@lists.linux.dev \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).