From: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
To: James Prestwood <prestwoj@gmail.com>
Cc: "Denis Kenzior" <denkenz@gmail.com>,
"Alvin Šipraga" <alvin@pqrs.dk>,
"iwd@lists.linux.dev" <iwd@lists.linux.dev>,
"Dimitrios Karnikis" <DIKA@bang-olufsen.dk>,
"Claudio Cabral" <CLCA@bang-olufsen.dk>,
"Pedro André" <PEDA@bang-olufsen.dk>,
"Johnny Kudahl" <JOY@bang-olufsen.dk>,
"achyut.hegde@nxp.com" <achyut.hegde@nxp.com>,
"yuvraj.singh@nxp.com" <yuvraj.singh@nxp.com>
Subject: Re: [PATCH] station: handle ROAMING state in disconnect event (again)
Date: Mon, 13 Nov 2023 15:45:19 +0000 [thread overview]
Message-ID: <dlgmutmqycq46gc2dtrlxo73yoif7ephoo6sb5hsdtj2j66yko@3xk5ll3ehg4x> (raw)
In-Reply-To: <068ee7ac-298a-4bab-971f-e4c797dbdd4b@gmail.com>
Hi James,
On Mon, Nov 13, 2023 at 07:29:14AM -0800, James Prestwood wrote:
> Hi Denis,
>
> On 11/13/23 7:26 AM, Denis Kenzior wrote:
> > Hi James,
> >
> > >
> > > Ok this does make sense to me. A disconnect from the AP could come
> > > in at any point during reassociation (during the ROAMING state). I
> > > think we assume the kernel handles this during the actual
> > > association step, i.e. relays this in the connect event, but during
> > > eapol/key setting I think your original patch holds some merit.
> > >
> > > Just so we have public record I've sanitized the logs you sent
> > > (removed dates, hostnames, driver prints), and its clear that a
> > > disconnect at this moment would trigger this "Unexpected disconnect"
> > > case:
> > >
> > > iwd[3589]: ../iwd-2.8/src/eapol.c:eapol_start()
> > > iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_link_notify() event 16 on
> > > ifindex 8
> > > iwd[3589]: ../iwd-2.8/src/eapol.c:eapol_handle_ptk_1_of_4() ifindex=8
> > > iwd[3589]: ../iwd-2.8/src/eapol.c:eapol_handle_ptk_3_of_4() ifindex=8
> > > iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_set_gtk() ifindex=8 key_idx=1
> > > iwd[3589]: ../iwd-2.8/src/station.c:station_handshake_event()
> > > Setting keys
>
> Hmm, good question. I didn't notice that but its called 2x in the logs Alvin
> sent me. Alvin, was it a copy-paste error on your side? If not something
> weird is going on.
It's my bad. I sent James a snippet in my email when attaching the logs and he
just pasted it back. Something must have gotten screwed up on my end while
copy-pasting. Here is the proper snippet one more time:
iwd[3589]: ../iwd-2.8/src/station.c:station_enter_state() Old State: connected, new state: roaming
iwd[3589]: ../iwd-2.8/src/wiphy.c:wiphy_radio_work_done() Work item 14 done
iwd[3589]: ../iwd-2.8/src/wiphy.c:wiphy_radio_work_next() Starting work item 15
iwd[3589]: ../iwd-2.8/src/station.c:station_netdev_event() Associating
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_mlme_notify() MLME notification Authenticate(37)
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_authenticate_event()
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_mlme_notify() MLME notification Associate(38)
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_associate_event()
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_mlme_notify() MLME notification Connect(46)
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_connect_event()
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_connect_event() aborting and ignore_connect_event not set, proceed
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_connect_event() expect_connect_failure not set, proceed
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_connect_event() Request / Response IEs parsed
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_get_oci()
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_link_notify() event 16 on ifindex 8
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_get_oci_cb() Obtained OCI: freq: 2412, width: 1, center1: 2412, center2: 0
iwd[3589]: ../iwd-2.8/src/eapol.c:eapol_start()
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_link_notify() event 16 on ifindex 8
iwd[3589]: ../iwd-2.8/src/eapol.c:eapol_handle_ptk_1_of_4() ifindex=8
iwd[3589]: ../iwd-2.8/src/eapol.c:eapol_handle_ptk_3_of_4() ifindex=8
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_set_gtk() ifindex=8 key_idx=1
iwd[3589]: ../iwd-2.8/src/station.c:station_handshake_event() Setting keys
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_set_tk() ifindex=8 key_idx=0
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_set_rekey_offload() 8
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_new_group_key_cb() ifindex: 8, err: 0
iwd[3589]: ../iwd-2.8/src/netdev.c:try_handshake_complete() ptk_installed: 0, gtk_installed: 1, igtk_installed: 1
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_mlme_notify() MLME notification Disassociate(40)
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_mlme_notify() MLME notification Disconnect(48)
iwd[3589]: ../iwd-2.8/src/netdev.c:netdev_disconnect_event()
iwd[3589]: Received Deauthentication event, reason: 1, from_ap: true
iwd[3589]: ../iwd-2.8/src/wiphy.c:wiphy_radio_work_done() Work item 15 done
iwd[3589]: ../iwd-2.8/src/station.c:station_disconnect_event() 8
iwd[3589]: Unexpected disconnect event
Sorry about that.
Kind regards,
Alvin
next prev parent reply other threads:[~2023-11-13 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 14:19 [PATCH] station: handle ROAMING state in disconnect event (again) Alvin Šipraga
2023-04-03 22:35 ` James Prestwood
2023-04-05 9:12 ` Alvin Šipraga
2023-04-30 10:22 ` Alvin Šipraga
2023-05-01 15:53 ` James Prestwood
2023-11-13 12:46 ` Alvin Šipraga
2023-11-13 13:10 ` James Prestwood
2023-11-13 15:22 ` Alvin Šipraga
2023-11-13 15:26 ` Denis Kenzior
2023-11-13 15:29 ` James Prestwood
2023-11-13 15:38 ` Denis Kenzior
2023-11-13 15:45 ` Alvin Šipraga [this message]
2023-11-13 15:20 ` Denis Kenzior
2023-11-13 15:39 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dlgmutmqycq46gc2dtrlxo73yoif7ephoo6sb5hsdtj2j66yko@3xk5ll3ehg4x \
--to=alsi@bang-olufsen.dk \
--cc=CLCA@bang-olufsen.dk \
--cc=DIKA@bang-olufsen.dk \
--cc=JOY@bang-olufsen.dk \
--cc=PEDA@bang-olufsen.dk \
--cc=achyut.hegde@nxp.com \
--cc=alvin@pqrs.dk \
--cc=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
--cc=yuvraj.singh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).