From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 1/3] wiphy: make wiphy_band_is_disabled return more descriptive
Date: Fri, 29 Sep 2023 21:59:02 -0500 [thread overview]
Message-ID: <b1b52ddf-9440-b9e5-fd3e-c15f39a2a631@gmail.com> (raw)
In-Reply-To: <20230929161959.3840935-1-prestwoj@gmail.com>
Hi James,
On 9/29/23 11:19, James Prestwood wrote:
> The function wiphy_band_is_disabled() return was a bit misleading
> because if the band was not supported it would return true which
> could be misunderstood as the band is supported, but disabled.
> There was only one call site and because of this behavior
> wiphy_band_is_disabled needed to be paired with checking if the
> band was supported.
>
> To be more descriptive to the called, wiphy_band_is_disabled() now
> returns an int and if the band isn't supported -ENOTSUP will be
> returned, otherwise true/false.
Returning true/false and -errno isn't a pattern we use. I changed this patch to
return -errno on error, 1 if disabled, and 0 otherwise. Also fixed up patch 2
as a result. Please double check that I didn't screw anything up.
> ---
> src/station.c | 4 +---
> src/wiphy.c | 4 ++--
> src/wiphy.h | 2 +-
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
All applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2023-09-30 2:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:19 [PATCH 1/3] wiphy: make wiphy_band_is_disabled return more descriptive James Prestwood
2023-09-29 16:19 ` [PATCH 2/3] scan: remove use of wiphy_get_allowed_freqs to optimize 6ghz path James Prestwood
2023-09-29 16:19 ` [PATCH 3/3] wiphy: remove wiphy_get_allowed_freqs James Prestwood
2023-09-30 2:59 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1b52ddf-9440-b9e5-fd3e-c15f39a2a631@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).