From: James Prestwood <prestwoj@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 1/7] handshake: Add cleanup function for handshake_state
Date: Fri, 1 Dec 2023 08:47:41 -0800 [thread overview]
Message-ID: <a8ddba3d-0e13-449f-840a-10f0cb980403@gmail.com> (raw)
In-Reply-To: <b6ea29ea-5fa8-4ac2-afea-3ff2507322eb@gmail.com>
Hi Denis,
On 12/1/23 08:32, Denis Kenzior wrote:
> Hi James,
>
>>> Nvm, I'm getting the 4 failures on a 6.6 kernel now. Something must
>>> have changed so I'll look into it.
>>
>> 6.2 - works
>>
>> 6.5 - works
>>
>> 6.6 - broken
>
> Sigh, figures. I doubt the patch from Johannes would fix anything for
> us since we don't query carrier state directly if I recall correctly.
> We only react to events, at least on the connect path.
Two separate things here:
- Confirmed that CQM events are broken at least in 6.6, this was the
patch I linked in this thread.
- Earlier email I sent about the carrier state was more of a suspected
problem for flaky tests, before I even saw the roaming tests were
failing. I haven't tried applying those kernel patches, but it would
also require userspace changes checking that extra attribute. I just
need to look more into this.
Anyways, yes, unfortunate. At it's also broken in wpa_supplicant so its
going to get a lot of visibility.
Thanks,
James
>
> Regards,
> -Denis
next prev parent reply other threads:[~2023-12-01 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 4:00 [PATCH 1/7] handshake: Add cleanup function for handshake_state Denis Kenzior
2023-12-01 4:00 ` [PATCH 2/7] p2p: Simplify handshake_state cleanup Denis Kenzior
2023-12-01 4:00 ` [PATCH 3/7] p2p: Simplify cleanup of ies Denis Kenzior
2023-12-01 4:00 ` [PATCH 4/7] netdev: iov_ie_append: Support iovecs with multiple IEs Denis Kenzior
2023-12-01 4:00 ` [PATCH 5/7] p2p: Use handshake to pass vendor ies Denis Kenzior
2023-12-01 4:00 ` [PATCH 6/7] wsc: " Denis Kenzior
2023-12-01 4:00 ` [PATCH 7/7] netdev: Remove vendor_ies from netdev_connect signature Denis Kenzior
2023-12-01 12:42 ` [PATCH 1/7] handshake: Add cleanup function for handshake_state James Prestwood
2023-12-01 15:08 ` Denis Kenzior
2023-12-01 15:22 ` James Prestwood
2023-12-01 15:32 ` James Prestwood
2023-12-01 16:06 ` James Prestwood
2023-12-01 16:32 ` Denis Kenzior
2023-12-01 16:47 ` James Prestwood [this message]
2023-12-01 16:30 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8ddba3d-0e13-449f-840a-10f0cb980403@gmail.com \
--to=prestwoj@gmail.com \
--cc=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).