From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 3/4] scan: add flag if BSS load was advertised
Date: Wed, 15 May 2024 05:22:20 -0700 [thread overview]
Message-ID: <20240515122221.333230-3-prestwoj@gmail.com> (raw)
In-Reply-To: <20240515122221.333230-1-prestwoj@gmail.com>
For ranking purposes the utilization was defaulted to a valid (127)
which would not change the rank if that IE was not found in the
scan results. Historically this was printed (debug) as part of the
scan results but that was removed as it was somewhat confusing. i.e.
did the AP _really_ have a utilization of 127? or was the IE not
found?
Since it is useful to see the BSS load if that is advertised add a
flag to the scan_bss struct to indicate if the IE was present which
can be checked.
---
src/scan.c | 14 ++++++++------
src/scan.h | 1 +
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/scan.c b/src/scan.c
index 8699fe3e..555ab88e 100644
--- a/src/scan.c
+++ b/src/scan.c
@@ -1344,6 +1344,8 @@ static bool scan_parse_bss_information_elements(struct scan_bss *bss,
NULL) < 0)
l_warn("Unable to parse BSS Load IE for "
MAC, MAC_STR(bss->addr));
+ else
+ bss->have_utilization = true;
break;
case IE_TYPE_VENDOR_SPECIFIC:
@@ -1533,7 +1535,6 @@ static struct scan_bss *scan_parse_attr_bss(struct l_genl_attr *attr,
size_t beacon_ies_len;
bss = l_new(struct scan_bss, 1);
- bss->utilization = 127;
bss->source_frame = SCAN_BSS_BEACON;
while (l_genl_attr_next(attr, &type, &len, &data)) {
@@ -1704,10 +1705,12 @@ static void scan_bss_compute_rank(struct scan_bss *bss)
rank *= RANK_6G_FACTOR;
/* Rank loaded APs lower and lightly loaded APs higher */
- if (bss->utilization >= 192)
- rank *= RANK_HIGH_UTILIZATION_FACTOR;
- else if (bss->utilization <= 63)
- rank *= RANK_LOW_UTILIZATION_FACTOR;
+ if (bss->have_utilization) {
+ if (bss->utilization >= 192)
+ rank *= RANK_HIGH_UTILIZATION_FACTOR;
+ else if (bss->utilization <= 63)
+ rank *= RANK_LOW_UTILIZATION_FACTOR;
+ }
if (bss->have_snr) {
if (bss->snr <= 15)
@@ -1734,7 +1737,6 @@ struct scan_bss *scan_bss_new_from_probe_req(const struct mmpdu_header *mpdu,
bss = l_new(struct scan_bss, 1);
memcpy(bss->addr, mpdu->address_2, 6);
- bss->utilization = 127;
bss->source_frame = SCAN_BSS_PROBE_REQ;
bss->frequency = frequency;
bss->signal_strength = rssi;
diff --git a/src/scan.h b/src/scan.h
index 0bfc9e47..06753b82 100644
--- a/src/scan.h
+++ b/src/scan.h
@@ -91,6 +91,7 @@ struct scan_bss {
bool sae_pw_id_used : 1;
bool sae_pw_id_exclusive : 1;
bool have_snr : 1;
+ bool have_utilization : 1;
};
struct scan_parameters {
--
2.34.1
next prev parent reply other threads:[~2024-05-15 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 12:22 [PATCH 1/4] nl80211util: add ATTR_SURVEY_INFO to parse_attrs James Prestwood
2024-05-15 12:22 ` [PATCH 2/4] scan: use GET_SURVEY for SNR calculation in ranking James Prestwood
2024-05-15 12:22 ` James Prestwood [this message]
2024-05-15 12:22 ` [PATCH 4/4] station: refactor the printing of scan results, print SNR/load James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515122221.333230-3-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).