From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 1/4] p2p: check connected peer before processing request
Date: Fri, 1 Mar 2024 11:40:53 -0800 [thread overview]
Message-ID: <20240301194056.1665549-1-prestwoj@gmail.com> (raw)
Caught by static analysis, the dev->conn_peer pointer was being
dereferenced very early on without a NULL check, but further it
was being NULL checked. If there is a possibility of it being NULL
the check should be done much earlier.
---
src/p2p.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/p2p.c b/src/p2p.c
index 08fe8444..205d4fcb 100644
--- a/src/p2p.c
+++ b/src/p2p.c
@@ -2310,6 +2310,9 @@ static void p2p_device_go_negotiation_req_cb(const struct mmpdu_header *mpdu,
if (!peer)
return;
+ if (!dev->conn_peer)
+ return;
+
if (body_len < 8)
return;
@@ -2438,7 +2441,7 @@ static void p2p_device_go_negotiation_req_cb(const struct mmpdu_header *mpdu,
memcpy(dev->conn_peer_interface_addr, req_info.intended_interface_addr,
6);
- if (dev->is_go && dev->conn_peer) {
+ if (dev->is_go) {
p2p_set_group_id(dev);
dev->conn_config_delay =
--
2.34.1
next reply other threads:[~2024-03-01 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 19:40 James Prestwood [this message]
2024-03-01 19:40 ` [PATCH 2/4] eap-mschapv2: Check Password-Hash exists when loading settings James Prestwood
2024-03-01 19:40 ` [PATCH 3/4] monitor: properly mask HE capabilities bitfield James Prestwood
2024-03-01 19:40 ` [PATCH 4/4] client: fix two issues caught by static analysis James Prestwood
2024-03-12 3:10 ` [PATCH 1/4] p2p: check connected peer before processing request Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301194056.1665549-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).