From: Fiona Klute <fiona.klute@gmx.de>
To: iwd@lists.linux.dev
Cc: Fiona Klute <fiona.klute@gmx.de>
Subject: [PATCH] Log falling back from SAE to WPA2
Date: Tue, 9 Jan 2024 10:59:26 +0100 [thread overview]
Message-ID: <20240109095926.1541238-1-fiona.klute@gmx.de> (raw)
I've had connections to a WPA3-Personal only network fail with no log
message from iwd, and eventually figured out to was because the driver
would've required using CMD_EXTERNAL_AUTH. With the added log messages
the reason becomes obvious.
Additionally the fallback may happen even if the user explicitly
configured WPA3 in NetworkManager, I believe a warning is appropriate
there.
---
src/wiphy.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/wiphy.c b/src/wiphy.c
index 766df348..5530e9c6 100644
--- a/src/wiphy.c
+++ b/src/wiphy.c
@@ -248,6 +248,8 @@ static bool wiphy_can_connect_sae(struct wiphy *wiphy)
*
* TODO: No support for CMD_EXTERNAL_AUTH yet.
*/
+ l_debug("Unsupported: %s needs CMD_EXTERNAL_AUTH for SAE",
+ wiphy->driver_str);
return false;
}
@@ -312,8 +314,10 @@ enum ie_rsn_akm_suite wiphy_select_akm(struct wiphy *wiphy,
if (ie_rsne_is_wpa3_personal(info)) {
l_debug("Network is WPA3-Personal...");
- if (!wiphy_can_connect_sae(wiphy))
+ if (!wiphy_can_connect_sae(wiphy)) {
+ l_warn("Can't use SAE, trying WPA-2");
goto wpa2_personal;
+ }
if (info->akm_suites &
IE_RSN_AKM_SUITE_FT_OVER_SAE_SHA256)
--
2.43.0
next reply other threads:[~2024-01-09 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 9:59 Fiona Klute [this message]
2024-01-10 3:33 ` [PATCH] Log falling back from SAE to WPA2 Denis Kenzior
2024-01-10 11:33 ` Fiona Klute
2024-01-10 16:51 ` Denis Kenzior
2024-01-10 13:12 ` Marcel Holtmann
2024-01-10 16:47 ` Denis Kenzior
2024-01-10 17:05 ` Marcel Holtmann
2024-01-10 17:10 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109095926.1541238-1-fiona.klute@gmx.de \
--to=fiona.klute@gmx.de \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).