From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v3 1/4] knownnetworks: Add UPDATED event
Date: Tue, 19 Dec 2023 10:08:23 -0800 [thread overview]
Message-ID: <20231219180826.201540-1-prestwoj@gmail.com> (raw)
If a known network is modified on disk known networks does not have
any way of notifying other modules. This will be needed to support a
corner case in DPP if a profile exists but is overwritten after DPP
configuration. Add this event to known networks and handle it in
network.c (though nothing needs to be done in that case).
---
src/knownnetworks.c | 4 ++++
src/knownnetworks.h | 1 +
src/network.c | 2 ++
3 files changed, 7 insertions(+)
v3:
* Removed bulk of this change, just emit UPDATED to let DPP know the
profile was seen by knownnetworks
diff --git a/src/knownnetworks.c b/src/knownnetworks.c
index d4d50a6f..04ce74ec 100644
--- a/src/knownnetworks.c
+++ b/src/knownnetworks.c
@@ -468,6 +468,10 @@ void known_network_update(struct network_info *network,
known_network_set_autoconnect(network, new->is_autoconnectable);
memcpy(&network->config, new, sizeof(struct network_config));
+
+ WATCHLIST_NOTIFY(&known_network_watches,
+ known_networks_watch_func_t,
+ KNOWN_NETWORKS_EVENT_UPDATED, network);
}
bool known_networks_foreach(known_networks_foreach_func_t function,
diff --git a/src/knownnetworks.h b/src/knownnetworks.h
index 0a5c9e25..e8ffac0b 100644
--- a/src/knownnetworks.h
+++ b/src/knownnetworks.h
@@ -35,6 +35,7 @@ struct network_info;
enum known_networks_event {
KNOWN_NETWORKS_EVENT_ADDED,
KNOWN_NETWORKS_EVENT_REMOVED,
+ KNOWN_NETWORKS_EVENT_UPDATED,
};
struct network_info_ops {
diff --git a/src/network.c b/src/network.c
index 3918ae08..4723334e 100644
--- a/src/network.c
+++ b/src/network.c
@@ -2033,6 +2033,8 @@ static void known_networks_changed(enum known_networks_event event,
case KNOWN_NETWORKS_EVENT_REMOVED:
station_foreach(emit_known_network_removed, (void *) info);
break;
+ case KNOWN_NETWORKS_EVENT_UPDATED:
+ break;
}
}
--
2.34.1
next reply other threads:[~2023-12-19 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 18:08 James Prestwood [this message]
2023-12-19 18:08 ` [PATCH v3 2/4] dpp: fix extra settings not being used when connecting James Prestwood
2023-12-19 18:08 ` [PATCH v3 3/4] auto-t: add DPP tests to check extra settings are applied James Prestwood
2023-12-19 18:08 ` [PATCH v3 4/4] auto-t: increase RAM when running with valgrind (UML) James Prestwood
2023-12-20 1:49 ` [PATCH v3 1/4] knownnetworks: Add UPDATED event Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219180826.201540-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).