From: Jens Axboe <axboe@kernel.dk>
To: Dylan Yudaken <dyudaken@gmail.com>
Cc: io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring/net: drop unused 'fast_iov_one' entry
Date: Wed, 20 Mar 2024 08:41:04 -0600 [thread overview]
Message-ID: <df071f2d-0dd1-4874-9ad7-d79389dd3084@kernel.dk> (raw)
In-Reply-To: <CAO_YeohJmpk=5463u3APYjqfoDB75m6rDZtQ10SPaL7TLG_D8Q@mail.gmail.com>
On 3/20/24 7:59 AM, Dylan Yudaken wrote:
> On Tue, Mar 19, 2024 at 11:37?PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Doesn't really matter at this point, as the fast_iov entries dominate
>> the size of io_async_msghdr. But that may not always be the case, so
>> drop this unused member. It turns out it got added in a previous commit,
>> but never actually used for anything.
>>
>> Fixes: 9bb66906f23e ("io_uring: support multishot in recvmsg")
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>>
>> ---
>>
>> diff --git a/io_uring/net.h b/io_uring/net.h
>> index 191009979bcb..9d7962f65f26 100644
>> --- a/io_uring/net.h
>> +++ b/io_uring/net.h
>> @@ -10,7 +10,6 @@ struct io_async_msghdr {
>> union {
>> struct iovec fast_iov[UIO_FASTIOV];
>> struct {
>> - struct iovec fast_iov_one;
>> __kernel_size_t controllen;
>> int namelen;
>> __kernel_size_t payloadlen;
>>
>
> I "believe" this is used in the async paths, where fast_iov[0] gets
> used (since multishot always has exactly one iovec) and so
> fast_iov_one is just a placeholder.
> I think that means it's not safe to remove until after your async patches.
Oh that's nasty, no comment about that, nor any direct use of it. Poor
shame on whoever wrote that code :-)
I'll double check.
--
Jens Axboe
prev parent reply other threads:[~2024-03-20 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 23:37 [PATCH] io_uring/net: drop unused 'fast_iov_one' entry Jens Axboe
2024-03-20 13:59 ` Dylan Yudaken
2024-03-20 14:41 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df071f2d-0dd1-4874-9ad7-d79389dd3084@kernel.dk \
--to=axboe@kernel.dk \
--cc=dyudaken@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).