From: Jens Axboe <axboe@kernel.dk>
To: io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring/poll: fix upper bits poll updating
Date: Wed, 13 Mar 2024 16:08:04 -0600 [thread overview]
Message-ID: <7e351f7a-3761-45a8-8b8c-91774082d277@kernel.dk> (raw)
In-Reply-To: <14abef4b-c217-4ec1-93d6-9c0950e972b9@kernel.dk>
On 3/13/24 3:26 PM, Jens Axboe wrote:
> If IORING_POLL_UPDATE_EVENTS is used to updated the mask of a pending
> poll request, then we mask off the bottom 16 bits and mask in the new
> ones. But this prevents updating higher entry bits, which wasn't the
> intent.
>
> Rather than play masking games, simply overwrite the existing poll
> entry mask with the new one.
This can't work, some of the upper flags will decide state. So just
disregard this one!
--
Jens Axboe
prev parent reply other threads:[~2024-03-13 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 21:26 [PATCH] io_uring/poll: fix upper bits poll updating Jens Axboe
2024-03-13 22:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e351f7a-3761-45a8-8b8c-91774082d277@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).