From: Jens Axboe <axboe@kernel.dk>
To: io-uring <io-uring@vger.kernel.org>,
Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: [PATCH] io_uring/net: improve the usercopy for sendmsg/recvmsg
Date: Mon, 26 Feb 2024 17:35:36 -0700 [thread overview]
Message-ID: <6db10bbb-cf34-4e81-a2ad-d14253d835d4@kernel.dk> (raw)
In-Reply-To: <3cbf09fa-74e6-42f7-ad98-27a48556ba29@kernel.dk>
On 2/26/24 4:54 PM, Jens Axboe wrote:
> @@ -305,11 +310,13 @@ static int __io_msg_copy_hdr(struct io_kiocb *req, struct io_async_msghdr *iomsg
> iomsg->fast_iov[0].iov_base = NULL;
> iomsg->free_iov = NULL;
> } else if (msg.msg_iovlen > 1) {
> - return -EINVAL;
> + ret = -EINVAL;
> + goto uaccess_end;
> } else {
> - if (copy_from_user(iomsg->fast_iov, msg.msg_iov,
> - sizeof(*msg.msg_iov)))
> - return -EFAULT;
> + unsafe_get_user(iomsg->fast_iov[0].iov_base,
> + &msg.msg_iov[0].iov_base, uaccess_end);
> + unsafe_get_user(iomsg->fast_iov[0].iov_len,
> + &msg.msg_iov[0].iov_len, uaccess_end);
> sr->len = iomsg->fast_iov[0].iov_len;
> iomsg->free_iov = NULL;
Missed an access_ok() in this section, the committed patch has it:
https://git.kernel.dk/cgit/linux/commit/?h=io_uring-send-queue&id=1a5c271af083bccfed400bad7105d9d06290bbf6
--
Jens Axboe
prev parent reply other threads:[~2024-02-27 0:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 23:54 [PATCH] io_uring/net: improve the usercopy for sendmsg/recvmsg Jens Axboe
2024-02-27 0:35 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db10bbb-cf34-4e81-a2ad-d14253d835d4@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).