From: Chenliang Li <cliang01.li@samsung.com>
To: axboe@kernel.dk
Cc: asml.silence@gmail.com, cliang01.li@samsung.com,
gost.dev@samsung.com, io-uring@vger.kernel.org,
joshi.k@samsung.com, kundan.kumar@samsung.com,
linux-kernel@vger.kernel.org, peiwei.li@samsung.com
Subject: Re: [PATCH] io_uring/rsrc: Add support for multi-folio buffer coalescing
Date: Tue, 7 May 2024 13:22:03 +0800 [thread overview]
Message-ID: <20240507052203.67459-1-cliang01.li@samsung.com> (raw)
In-Reply-To: <71c1f01f-f740-43b0-9962-afcf08cab686@kernel.dk>
On 5/6/24 6:57 AM, Jens Axboe wrote:
> Can you add some justification to this commit message? A good commit
> message should basically be the WHY of why this commit exists in the
> first place. Your commit message just explains what the patch does,
> which I can just read the code to see for myself.
>
> As it stands, it's not clear to me or anyone casually reading this
> commit message why the change is being done in the first place.
Thank you for the instruction. I'll submit a V2 patchset with better
commit message.
> Outside of that, you probably want to split this into two parts - one
> that adds the helper for the existing code, then one that modifies it
> for your change. We need this to be as simple as possible to review, as
> we've had a security issue with page coalescing in this code in the
> past.
Will split this in V2.
> Minor comments below, will wait with a full review until this is split
> to be more easily reviewable.
Thank you for the comments. Will address them in V2.
prev parent reply other threads:[~2024-05-07 5:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240506075314epcas5p25333b80c8d6a3217d5352a5a7ed89278@epcas5p2.samsung.com>
2024-05-06 7:53 ` [PATCH] io_uring/rsrc: Add support for multi-folio buffer coalescing Chenliang Li
2024-05-06 12:57 ` Jens Axboe
[not found] ` <CGME20240507052214epcas5p351e1ff563e3d62bf1fff305dccc1905c@epcas5p3.samsung.com>
2024-05-07 5:22 ` Chenliang Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507052203.67459-1-cliang01.li@samsung.com \
--to=cliang01.li@samsung.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kundan.kumar@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peiwei.li@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).