From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org
Subject: [PATCHSET v2 0/3] Support for provided buffers for send
Date: Mon, 19 Feb 2024 14:25:24 -0700 [thread overview]
Message-ID: <20240219212748.3826830-1-axboe@kernel.dk> (raw)
Hi,
We never supported provided buffers for sends, because it didn't seem
to make a lot of sense. But it actually does make a lot of sense! If
an app is receiving data, doing something with it, and then sending
either the same or another buffer out based on that, then if we use
provided buffers for sends we can guarantee that the sends are
serialized. This is because provided buffer rings are FIFO ordered,
as it's a ring buffer, and hence it doesn't really matter if you
have more than one send inflight.
This provides a nice efficiency win, but more importantly, it reduces
the complexity in the application as it no longer needs to track a
potential backlog of sends. The app just sets up a send based buffer
ring, exactly like it does for incoming data. And that's it, no more
dealing with serialized sends.
In some testing with proxy [1], in basic shuffling of packets I see
a 36% improvement with this over manually dealing with sends. That's
a pretty big win on top of making the app simpler.
This also opens the door for multishot send requests, which is an
interesting future venue to pursue!
You can also find the patches here:
https://git.kernel.dk/cgit/linux/log/?h=io_uring-send-queue
[1] https://git.kernel.dk/cgit/liburing/tree/examples/proxy.c
Changes since v1:
- Forgot that the sendmsg side uses the generic helper for this, whereas
recvmsg rolls its own to deal with provided buffers. Unify them in patch
1 instead.
include/uapi/linux/io_uring.h | 1 +
io_uring/io_uring.c | 3 +-
io_uring/net.c | 309 +++++++++++++++++++---------------
io_uring/opdef.c | 2 +
4 files changed, 175 insertions(+), 140 deletions(-)
--
Jens Axboe
next reply other threads:[~2024-02-19 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 21:25 Jens Axboe [this message]
2024-02-19 21:25 ` [PATCH 1/3] io_uring/net: unify how recvmsg and sendmsg copy in the msghdr Jens Axboe
2024-02-19 21:25 ` [PATCH 2/3] io_uring/net: add provided buffer support for IORING_OP_SEND Jens Axboe
2024-02-19 21:25 ` [PATCH 3/3] io_uring/net: add provided buffer support for IORING_OP_SENDMSG Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219212748.3826830-1-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).