From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/xe/display: Fix ADL-N detection
Date: Fri, 26 Apr 2024 16:54:27 -0500 [thread overview]
Message-ID: <fjyhta7dbrgdfddj5zhbq2ekzspsfxakthxechucbj4jhhhpu3@pwy22mqasdr3> (raw)
In-Reply-To: <20240425182230.GB7068@mdroper-desk1.amr.corp.intel.com>
On Thu, Apr 25, 2024 at 11:22:30AM GMT, Matt Roper wrote:
>On Thu, Apr 25, 2024 at 11:16:09AM -0700, Lucas De Marchi wrote:
>> Contrary to i915, in xe ADL-N is kept as a different platform, not a
>> subplatform of ADL-P. Since the display side doesn't need to
>> differentiate between P and N, i.e. IS_ALDERLAKE_P_N() is never called,
>> just fixup the compat header to check for both P and N.
>>
>> Moving ADL-N to be a subplatform would be more complex as the firmware
>> loading in xe only handles platforms, not subplatforms, as going forward
>> the direction is to check on IP version rather than
>> platforms/subplatforms.
>>
>> Fix warning when initializing display:
>>
>> xe 0000:00:02.0: [drm:intel_pch_type [xe]] Found Alder Lake PCH
>> ------------[ cut here ]------------
>> xe 0000:00:02.0: drm_WARN_ON(!((dev_priv)->info.platform == XE_ALDERLAKE_S) && !((dev_priv)->info.platform == XE_ALDERLAKE_P))
>>
>> And wrong paths being taken on the display side.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>ADL-N uses exactly the same display IP as ADL-P (unlike on the GT side
>where they differ), so
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
applied, thanks
Lucas De Marchi
next prev parent reply other threads:[~2024-04-26 21:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:16 [PATCH] drm/xe/display: Fix ADL-N detection Lucas De Marchi
2024-04-25 18:21 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-25 18:21 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-25 18:22 ` ✓ CI.KUnit: success " Patchwork
2024-04-25 18:22 ` [PATCH] " Matt Roper
2024-04-26 21:54 ` Lucas De Marchi [this message]
2024-04-25 18:35 ` ✓ CI.Build: success for " Patchwork
2024-04-25 18:43 ` ✗ CI.Hooks: failure " Patchwork
2024-04-25 18:44 ` ✗ CI.checksparse: warning " Patchwork
2024-04-25 19:11 ` ✓ CI.BAT: success " Patchwork
2024-04-26 13:45 ` ✓ CI.Patch_applied: success for drm/xe/display: Fix ADL-N detection (rev2) Patchwork
2024-04-26 13:46 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-26 13:47 ` ✓ CI.KUnit: success " Patchwork
2024-04-26 13:59 ` ✓ CI.Build: " Patchwork
2024-04-26 14:01 ` ✓ CI.Hooks: " Patchwork
2024-04-26 14:03 ` ✓ CI.checksparse: " Patchwork
2024-04-26 14:34 ` ✓ CI.BAT: " Patchwork
2024-04-26 17:54 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fjyhta7dbrgdfddj5zhbq2ekzspsfxakthxechucbj4jhhhpu3@pwy22mqasdr3 \
--to=lucas.demarchi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).