From: "Souza, Jose" <jose.souza@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Upadhyay, Tejas" <tejas.upadhyay@intel.com>
Subject: Re: [PATCH V2] drm/xe: skip error capture when exec queue is killed
Date: Thu, 2 May 2024 13:56:40 +0000 [thread overview]
Message-ID: <a869acfa2cad759a10330926274dc24b1b02e9f4.camel@intel.com> (raw)
In-Reply-To: <20240430131229.2228809-1-tejas.upadhyay@intel.com>
On Tue, 2024-04-30 at 18:42 +0530, Tejas Upadhyay wrote:
> When user closes exec queue soon after job submission,
> we are generating error coredump. Instead check if
> exec queue is killed during job timeout then skip
> error coredump capture.
Where this is happening?
Iris/OpenGL driver was not waiting for exec queue to idle and it was causing '*ERROR* GT0: TLB invalidation' errors in Xe KMD.
That was fixed here: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27500/diffs?commit_id=665d30b5448f606d7a79afe0596c3a2264ab3e15
ANV/Vulkan driver should already do that.
The patch looks good but UMD or IGT needs to be fixed too.
>
> V2:
> - Just skip error capture - MattB
>
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index d274a139010b..2c0aa3443cd9 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -980,8 +980,10 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
> xe_gt_WARN(q->gt, q->flags & EXEC_QUEUE_FLAG_VM && !exec_queue_killed(q),
> "VM job timed out on non-killed execqueue\n");
>
> - simple_error_capture(q);
> - xe_devcoredump(job);
> + if (!exec_queue_killed(q)) {
> + simple_error_capture(q);
> + xe_devcoredump(job);
> + }
>
> trace_xe_sched_job_timedout(job);
>
prev parent reply other threads:[~2024-05-02 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 13:12 [PATCH V2] drm/xe: skip error capture when exec queue is killed Tejas Upadhyay
2024-04-30 13:03 ` ✓ CI.Patch_applied: success for drm/xe: skip error capture when exec queue is killed (rev2) Patchwork
2024-04-30 13:04 ` ✓ CI.checkpatch: " Patchwork
2024-04-30 13:05 ` ✓ CI.KUnit: " Patchwork
2024-05-01 3:52 ` [PATCH V2] drm/xe: skip error capture when exec queue is killed Matthew Brost
2024-05-01 21:11 ` ✓ CI.Patch_applied: success for drm/xe: skip error capture when exec queue is killed (rev3) Patchwork
2024-05-01 21:12 ` ✓ CI.checkpatch: " Patchwork
2024-05-01 21:12 ` ✓ CI.KUnit: " Patchwork
2024-05-01 21:24 ` ✓ CI.Build: " Patchwork
2024-05-01 21:27 ` ✓ CI.Hooks: " Patchwork
2024-05-01 21:28 ` ✓ CI.checksparse: " Patchwork
2024-05-01 21:50 ` ✓ CI.BAT: " Patchwork
2024-05-01 22:50 ` ✓ CI.FULL: " Patchwork
2024-05-02 13:56 ` Souza, Jose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a869acfa2cad759a10330926274dc24b1b02e9f4.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=tejas.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).