From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
"Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
Subject: Re: [PATCH 1/2] drm/xe/display: remove unused xe->enabled_irq_mask
Date: Mon, 13 May 2024 22:56:46 +0300 [thread overview]
Message-ID: <87ikzheb9d.fsf@intel.com> (raw)
In-Reply-To: <djou7im7ge6emdfqjvev5u24ruhrqwa45a3sxtmbgjp3dra5cz@jtmpz6f3e4fv>
On Mon, 13 May 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Mon, May 13, 2024 at 03:10:29PM GMT, Jani Nikula wrote:
>>On Fri, 10 May 2024, Jani Nikula <jani.nikula@intel.com> wrote:
>>> The xe->enabled_irq_mask member has never been used for anything.
>>>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>>Lucas, ack for merging these two via drm-intel-next? Even though these
>>touch struct xe_device, I presume any further cleanups touching the
>>surrounding context would have a bigger footprint in drm-intel-next.
>
>
>
> Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> for both patches
Thanks for the review and acks, pushed to drm-intel-next.
BR,
Jani.
>
> thanks,
> Lucas De Marchi
>
>>
>>BR,
>>Jani.
>>
>>> ---
>>> drivers/gpu/drm/xe/display/xe_display.c | 1 -
>>> drivers/gpu/drm/xe/xe_device_types.h | 2 --
>>> 2 files changed, 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
>>> index 0de0566e5b39..fbe2c2eddea9 100644
>>> --- a/drivers/gpu/drm/xe/display/xe_display.c
>>> +++ b/drivers/gpu/drm/xe/display/xe_display.c
>>> @@ -97,7 +97,6 @@ int xe_display_create(struct xe_device *xe)
>>> xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
>>>
>>> drmm_mutex_init(&xe->drm, &xe->sb_lock);
>>> - xe->enabled_irq_mask = ~0;
>>>
>>> return drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
>>> }
>>> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
>>> index 906b98fb973b..b78223e3baab 100644
>>> --- a/drivers/gpu/drm/xe/xe_device_types.h
>>> +++ b/drivers/gpu/drm/xe/xe_device_types.h
>>> @@ -517,8 +517,6 @@ struct xe_device {
>>> /* only to allow build, not used functionally */
>>> u32 irq_mask;
>>>
>>> - u32 enabled_irq_mask;
>>> -
>>> struct intel_uncore {
>>> spinlock_t lock;
>>> } uncore;
>>
>>--
>>Jani Nikula, Intel
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-05-13 19:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 9:43 [PATCH 1/2] drm/xe/display: remove unused xe->enabled_irq_mask Jani Nikula
2024-05-10 9:43 ` [PATCH 2/2] drm/xe/display: remove unused xe->sb_lock Jani Nikula
2024-05-10 11:28 ` Ghimiray, Himal Prasad
2024-05-10 9:49 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/display: remove unused xe->enabled_irq_mask Patchwork
2024-05-10 9:50 ` ✓ CI.checkpatch: " Patchwork
2024-05-10 9:52 ` ✓ CI.KUnit: " Patchwork
2024-05-10 10:06 ` ✓ CI.Build: " Patchwork
2024-05-10 10:09 ` ✓ CI.Hooks: " Patchwork
2024-05-10 10:10 ` ✓ CI.checksparse: " Patchwork
2024-05-10 10:46 ` ✓ CI.BAT: " Patchwork
2024-05-10 11:30 ` [PATCH 1/2] " Ghimiray, Himal Prasad
2024-05-10 12:15 ` ✗ CI.FULL: failure for series starting with [1/2] " Patchwork
2024-05-13 12:10 ` [PATCH 1/2] " Jani Nikula
2024-05-13 14:35 ` Lucas De Marchi
2024-05-13 19:56 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikzheb9d.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).