From: "Dong, Zhanjun" <zhanjun.dong@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: Re: [PATCH v8 0/5] drm/xe/guc: Add GuC based register capture for error capture
Date: Fri, 3 May 2024 12:53:17 -0400 [thread overview]
Message-ID: <863864ea-21cd-47dc-a867-6d5b1accd69c@intel.com> (raw)
In-Reply-To: <20240502205738.863369-1-zhanjun.dong@intel.com>
Please ignore this series, patch #1 and #2 was accidently squashed
together. I will respin another rev 8 to keep the steering register list
handling as #2.
Regards,
Zhanjun
On 2024-05-02 4:57 p.m., Zhanjun Dong wrote:
> Port GuC based register capture for error capture from i915 to Xe.
>
> There are 3 parts inside:
> . Prepare for capture registers
> There is a bo create at guc ads init time, that is very early
> and engi ne map is not ready, make it hard to calculate the
> capture buffer size, new function created for worst case size
> caluation. Other than that, this part basically follows the i915
> design.
> . Process capture notification message
> Basically follows i915 design
> . Sysfs command process.
> Xe switched to devcoredump, adopted command line process with
> captured node list.
>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
>
> Changes from prior revs:
> v8:- Reorgnize the order of patches
> Change the capture size check from worst min size to worst size
> Replace the kernel alloc with drm managed alloc
> Replace the memcpy with xe_map_memcpy_from
> Free GuC capture outlist as part of xe_devcoredump_free
> v7:- Kconfig CONFIG_DRM_XE_CAPTURE_ERROR removed
> v6:- Change hardcoded register snapshot fill to follow mapping tables
> When capture is empty, take snapshot from engine
> v5:- Split dss helper code out as an standalone patch
> Remove old platform registers definition.
> Split register map table to 32 and 64bit each
> v4:- Move register map table to xe_hw_engine.c
> v3:- Remove condition compilation in code
> v2:- Split into multiple chunks
>
> Zhanjun Dong (5):
> drm/xe/guc: Prepare GuC register list and update ADS size for error
> capture
> drm/xe/guc: Add capture size check in GuC log buffer
> drm/xe/guc: Pre-allocate output nodes for extraction
> drm/xe/guc: Extract GuC error capture lists
> drm/xe/guc: Plumb GuC-capture into dev coredump
>
> drivers/gpu/drm/xe/Makefile | 1 +
> drivers/gpu/drm/xe/abi/guc_actions_abi.h | 7 +
> drivers/gpu/drm/xe/xe_devcoredump.c | 2 +
> drivers/gpu/drm/xe/xe_gt_printk.h | 3 +
> drivers/gpu/drm/xe/xe_guc.c | 5 +
> drivers/gpu/drm/xe/xe_guc.h | 5 +
> drivers/gpu/drm/xe/xe_guc_ads.c | 208 +++-
> drivers/gpu/drm/xe/xe_guc_ads.h | 3 +
> drivers/gpu/drm/xe/xe_guc_ads_types.h | 2 +
> drivers/gpu/drm/xe/xe_guc_capture.c | 1223 ++++++++++++++++++++++
> drivers/gpu/drm/xe/xe_guc_capture.h | 20 +
> drivers/gpu/drm/xe/xe_guc_capture_fwif.h | 221 ++++
> drivers/gpu/drm/xe/xe_guc_ct.c | 2 +
> drivers/gpu/drm/xe/xe_guc_fwif.h | 70 ++
> drivers/gpu/drm/xe/xe_guc_log.c | 179 ++++
> drivers/gpu/drm/xe/xe_guc_log.h | 15 +
> drivers/gpu/drm/xe/xe_guc_log_types.h | 24 +
> drivers/gpu/drm/xe/xe_guc_submit.c | 54 +-
> drivers/gpu/drm/xe/xe_guc_submit.h | 2 +
> drivers/gpu/drm/xe/xe_guc_types.h | 2 +
> drivers/gpu/drm/xe/xe_hw_engine.c | 249 +++--
> drivers/gpu/drm/xe/xe_hw_engine.h | 4 +
> drivers/gpu/drm/xe/xe_hw_engine_types.h | 150 ++-
> drivers/gpu/drm/xe/xe_sched_job.c | 7 +-
> 24 files changed, 2308 insertions(+), 150 deletions(-)
> create mode 100644 drivers/gpu/drm/xe/xe_guc_capture.c
> create mode 100644 drivers/gpu/drm/xe/xe_guc_capture.h
> create mode 100644 drivers/gpu/drm/xe/xe_guc_capture_fwif.h
>
prev parent reply other threads:[~2024-05-03 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 20:57 [PATCH v8 0/5] drm/xe/guc: Add GuC based register capture for error capture Zhanjun Dong
2024-05-02 20:57 ` [PATCH v8 1/5] drm/xe/guc: Prepare GuC register list and update ADS size " Zhanjun Dong
2024-05-02 20:57 ` [PATCH v8 2/5] drm/xe/guc: Add capture size check in GuC log buffer Zhanjun Dong
2024-05-02 20:57 ` [PATCH v8 3/5] drm/xe/guc: Pre-allocate output nodes for extraction Zhanjun Dong
2024-05-02 20:57 ` [PATCH v8 4/5] drm/xe/guc: Extract GuC error capture lists Zhanjun Dong
2024-05-02 20:57 ` [PATCH v8 5/5] drm/xe/guc: Plumb GuC-capture into dev coredump Zhanjun Dong
2024-05-02 21:30 ` ✓ CI.Patch_applied: success for drm/xe/guc: Add GuC based register capture for error capture (rev7) Patchwork
2024-05-02 21:31 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-02 21:32 ` ✓ CI.KUnit: success " Patchwork
2024-05-02 21:45 ` ✓ CI.Build: " Patchwork
2024-05-02 21:47 ` ✗ CI.Hooks: failure " Patchwork
2024-05-02 21:52 ` ✓ CI.checksparse: success " Patchwork
2024-05-02 22:24 ` ✗ CI.BAT: failure " Patchwork
2024-05-02 23:58 ` ✗ CI.FULL: " Patchwork
2024-05-03 16:53 ` Dong, Zhanjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863864ea-21cd-47dc-a867-6d5b1accd69c@intel.com \
--to=zhanjun.dong@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).