From: Lucas De Marchi <lucas.demarchi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: [CI 3/5] drm/xe: Move xe_gt_init_early() where it belongs
Date: Mon, 13 May 2024 14:37:49 -0700 [thread overview]
Message-ID: <20240513213751.1017791-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20240513213751.1017791-1-lucas.demarchi@intel.com>
Early shall be early enough, stop doing other things with gt before it.
Now that xe_gt_init_early() doesn't need forcewake and doesn't depend on
the fake engine_mask initialization, move it where it belongs: it
doesn't need to be after hwconfig config anymore.
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index f89c781986a5..b08d4f213302 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -568,6 +568,12 @@ int xe_device_probe(struct xe_device *xe)
xe_ttm_sys_mgr_init(xe);
+ for_each_gt(gt, xe, id) {
+ err = xe_gt_init_early(gt);
+ if (err)
+ return err;
+ }
+
for_each_gt(gt, xe, id)
xe_force_wake_init_gt(gt, gt_to_fw(gt));
@@ -606,12 +612,6 @@ int xe_device_probe(struct xe_device *xe)
if (err)
goto err;
- for_each_gt(gt, xe, id) {
- err = xe_gt_init_early(gt);
- if (err)
- goto err_irq_shutdown;
- }
-
err = xe_device_set_has_flat_ccs(xe);
if (err)
goto err_irq_shutdown;
--
2.43.0
next prev parent reply other threads:[~2024-05-13 21:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 21:37 [CI 1/5] drm/xe: Drop __engine_mask Lucas De Marchi
2024-05-13 21:37 ` [CI 2/5] drm/xe: Drop useless forcewake get/put Lucas De Marchi
2024-05-13 21:37 ` Lucas De Marchi [this message]
2024-05-13 21:37 ` [CI 4/5] drm/xe: Move xe_force_wake_init_gt() inside gt initialization Lucas De Marchi
2024-05-13 21:37 ` [CI 5/5] drm/xe: Move sw-only pcode initialization Lucas De Marchi
2024-05-13 21:42 ` ✓ CI.Patch_applied: success for series starting with [CI,1/5] drm/xe: Drop __engine_mask Patchwork
2024-05-13 21:42 ` ✓ CI.checkpatch: " Patchwork
2024-05-13 21:43 ` ✓ CI.KUnit: " Patchwork
2024-05-13 21:55 ` ✓ CI.Build: " Patchwork
2024-05-13 21:57 ` ✓ CI.Hooks: " Patchwork
2024-05-13 21:59 ` ✓ CI.checksparse: " Patchwork
2024-05-13 22:20 ` ✓ CI.BAT: " Patchwork
2024-05-13 23:54 ` ✗ CI.FULL: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-05-09 4:12 [CI 1/5] " Lucas De Marchi
2024-05-09 4:12 ` [CI 3/5] drm/xe: Move xe_gt_init_early() where it belongs Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513213751.1017791-3-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).