From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Tejas Upadhyay <tejas.upadhyay@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: [PATCH] drm/xe: Modify minimum of various scheduler timeout to 0
Date: Mon, 6 May 2024 19:04:47 +0530 [thread overview]
Message-ID: <20240506133447.3143994-1-himal.prasad.ghimiray@intel.com> (raw)
Remove the min/max configs and change minimum values of preemption and
timeslice to 0. The sysman teams must deactivate preemption and
timeslice to assess exclusivity mode. They depend on configuring
timeslice_duration_us and preempt_timeout_us to 0, ensuring these
values are set at their minimum.
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
---
drivers/gpu/drm/xe/Kconfig.profile | 38 ------------------------------
drivers/gpu/drm/xe/xe_hw_engine.h | 28 ++--------------------
2 files changed, 2 insertions(+), 64 deletions(-)
diff --git a/drivers/gpu/drm/xe/Kconfig.profile b/drivers/gpu/drm/xe/Kconfig.profile
index ba17a25e8db3..9bf7adb45eea 100644
--- a/drivers/gpu/drm/xe/Kconfig.profile
+++ b/drivers/gpu/drm/xe/Kconfig.profile
@@ -1,27 +1,3 @@
-config DRM_XE_JOB_TIMEOUT_MAX
- int "Default max job timeout (ms)"
- default 10000 # milliseconds
- help
- Configures the default max job timeout after which job will
- be forcefully taken away from scheduler.
-config DRM_XE_JOB_TIMEOUT_MIN
- int "Default min job timeout (ms)"
- default 1 # milliseconds
- help
- Configures the default min job timeout after which job will
- be forcefully taken away from scheduler.
-config DRM_XE_TIMESLICE_MAX
- int "Default max timeslice duration (us)"
- default 10000000 # microseconds
- help
- Configures the default max timeslice duration between multiple
- contexts by guc scheduling.
-config DRM_XE_TIMESLICE_MIN
- int "Default min timeslice duration (us)"
- default 1 # microseconds
- help
- Configures the default min timeslice duration between multiple
- contexts by guc scheduling.
config DRM_XE_PREEMPT_TIMEOUT
int "Preempt timeout (us, jiffy granularity)"
default 640000 # microseconds
@@ -30,20 +6,6 @@ config DRM_XE_PREEMPT_TIMEOUT
when submitting a new context. If the current context does not hit
an arbitration point and yield to HW before the timer expires, the
HW will be reset to allow the more important context to execute.
-config DRM_XE_PREEMPT_TIMEOUT_MAX
- int "Default max preempt timeout (us)"
- default 10000000 # microseconds
- help
- Configures the default max preempt timeout after which context
- will be forcefully taken away and higher priority context will
- run.
-config DRM_XE_PREEMPT_TIMEOUT_MIN
- int "Default min preempt timeout (us)"
- default 1 # microseconds
- help
- Configures the default min preempt timeout after which context
- will be forcefully taken away and higher priority context will
- run.
config DRM_XE_ENABLE_SCHEDTIMEOUT_LIMIT
bool "Default configuration of limitation on scheduler timeout"
default y
diff --git a/drivers/gpu/drm/xe/xe_hw_engine.h b/drivers/gpu/drm/xe/xe_hw_engine.h
index 71968ee2f600..803555c601ec 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.h
+++ b/drivers/gpu/drm/xe/xe_hw_engine.h
@@ -10,41 +10,17 @@
struct drm_printer;
-#ifdef CONFIG_DRM_XE_JOB_TIMEOUT_MIN
-#define XE_HW_ENGINE_JOB_TIMEOUT_MIN CONFIG_DRM_XE_JOB_TIMEOUT_MIN
-#else
#define XE_HW_ENGINE_JOB_TIMEOUT_MIN 1
-#endif
-#ifdef CONFIG_DRM_XE_JOB_TIMEOUT_MAX
-#define XE_HW_ENGINE_JOB_TIMEOUT_MAX CONFIG_DRM_XE_JOB_TIMEOUT_MAX
-#else
#define XE_HW_ENGINE_JOB_TIMEOUT_MAX (10 * 1000)
-#endif
-#ifdef CONFIG_DRM_XE_TIMESLICE_MIN
-#define XE_HW_ENGINE_TIMESLICE_MIN CONFIG_DRM_XE_TIMESLICE_MIN
-#else
-#define XE_HW_ENGINE_TIMESLICE_MIN 1
-#endif
-#ifdef CONFIG_DRM_XE_TIMESLICE_MAX
-#define XE_HW_ENGINE_TIMESLICE_MAX CONFIG_DRM_XE_TIMESLICE_MAX
-#else
+#define XE_HW_ENGINE_TIMESLICE_MIN 0
#define XE_HW_ENGINE_TIMESLICE_MAX (10 * 1000 * 1000)
-#endif
#ifdef CONFIG_DRM_XE_PREEMPT_TIMEOUT
#define XE_HW_ENGINE_PREEMPT_TIMEOUT CONFIG_DRM_XE_PREEMPT_TIMEOUT
#else
#define XE_HW_ENGINE_PREEMPT_TIMEOUT (640 * 1000)
#endif
-#ifdef CONFIG_DRM_XE_PREEMPT_TIMEOUT_MIN
-#define XE_HW_ENGINE_PREEMPT_TIMEOUT_MIN CONFIG_DRM_XE_PREEMPT_TIMEOUT_MIN
-#else
-#define XE_HW_ENGINE_PREEMPT_TIMEOUT_MIN 1
-#endif
-#ifdef CONFIG_DRM_XE_PREEMPT_TIMEOUT_MAX
-#define XE_HW_ENGINE_PREEMPT_TIMEOUT_MAX CONFIG_DRM_XE_PREEMPT_TIMEOUT_MAX
-#else
+#define XE_HW_ENGINE_PREEMPT_TIMEOUT_MIN 0
#define XE_HW_ENGINE_PREEMPT_TIMEOUT_MAX (10 * 1000 * 1000)
-#endif
int xe_hw_engines_init_early(struct xe_gt *gt);
int xe_hw_engines_init(struct xe_gt *gt);
--
2.25.1
next reply other threads:[~2024-05-06 13:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 13:34 Himal Prasad Ghimiray [this message]
2024-05-06 14:11 ` ✓ CI.Patch_applied: success for drm/xe: Modify minimum of various scheduler timeout to 0 Patchwork
2024-05-06 14:11 ` ✓ CI.checkpatch: " Patchwork
2024-05-06 14:13 ` ✓ CI.KUnit: " Patchwork
2024-05-06 14:29 ` ✓ CI.Build: " Patchwork
2024-05-06 14:35 ` ✓ CI.Hooks: " Patchwork
2024-05-06 14:37 ` ✓ CI.checksparse: " Patchwork
2024-05-06 15:10 ` ✓ CI.BAT: " Patchwork
2024-05-06 16:47 ` ✓ CI.FULL: " Patchwork
2024-05-08 5:35 ` [PATCH] " Upadhyay, Tejas
2024-05-08 13:06 ` Lucas De Marchi
2024-05-09 16:00 ` Matthew Brost
2024-05-10 9:09 ` Joonas Lahtinen
2024-05-10 9:44 ` Ghimiray, Himal Prasad
2024-05-14 10:17 ` Konda, SaiKishore
2024-05-16 10:09 ` Ayaz A Siddiqui
-- strict thread matches above, loose matches on Subject: below --
2024-03-08 11:00 Himal Prasad Ghimiray
2024-04-05 4:53 ` Upadhyay, Tejas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506133447.3143994-1-himal.prasad.ghimiray@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=tejas.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).