From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: [PATCH v4 1/4] drm/xe: Remove safety check from __xe_ttm_stolen_io_mem_reserve_stolen
Date: Mon, 6 May 2024 12:36:01 +0200 [thread overview]
Message-ID: <20240506103604.146146-2-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20240506103604.146146-1-maarten.lankhorst@linux.intel.com>
This is invalid with display code when reworking DPT pinning.
The only reason we added it, was because originally all display
allocations also had the bit set.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c b/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c
index f77367329760..1613290b9eda 100644
--- a/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c
+++ b/drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c
@@ -298,10 +298,6 @@ static int __xe_ttm_stolen_io_mem_reserve_stolen(struct xe_device *xe,
XE_WARN_ON(IS_DGFX(xe));
- /* XXX: Require BO to be mapped to GGTT? */
- if (drm_WARN_ON(&xe->drm, !(bo->flags & XE_BO_FLAG_GGTT)))
- return -EIO;
-
/* GGTT is always contiguously mapped */
mem->bus.offset = xe_bo_ggtt_addr(bo) + mgr->io_base;
--
2.43.0
next prev parent reply other threads:[~2024-05-06 10:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 10:36 [PATCH v4 0/4] drm/xe: More fb pinning optimizations Maarten Lankhorst
2024-05-06 10:36 ` Maarten Lankhorst [this message]
2024-05-10 1:41 ` [PATCH v4 1/4] drm/xe: Remove safety check from __xe_ttm_stolen_io_mem_reserve_stolen Rodrigo Vivi
2024-05-06 10:36 ` [PATCH v4 2/4] drm/xe/display: Preparations for preallocating dpt bo Maarten Lankhorst
2024-05-10 1:45 ` Rodrigo Vivi
2024-05-06 10:36 ` [PATCH v4 3/4] drm/xe: Use simple xchg to cache DPT Maarten Lankhorst
2024-05-06 10:36 ` [PATCH v4 4/4] drm/xe/display: Re-use display vmas when possible Maarten Lankhorst
2024-05-06 11:14 ` ✓ CI.Patch_applied: success for drm/xe: More fb pinning optimizations Patchwork
2024-05-06 11:14 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-06 11:15 ` ✓ CI.KUnit: success " Patchwork
2024-05-06 11:28 ` ✓ CI.Build: " Patchwork
2024-05-06 11:31 ` ✓ CI.Hooks: " Patchwork
2024-05-06 11:32 ` ✗ CI.checksparse: warning " Patchwork
2024-05-06 12:11 ` ✓ CI.BAT: success " Patchwork
2024-05-06 13:22 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506103604.146146-2-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).