From: "Piotr Piórkowski" <piotr.piorkowski@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/xe/pf: Initialize and update PF services on driver init
Date: Fri, 26 Apr 2024 11:17:15 +0200 [thread overview]
Message-ID: <20240426091715.zhkclnw5lzn2xbs5@intel.com> (raw)
In-Reply-To: <20240425143927.2265-2-michal.wajdeczko@intel.com>
Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on czw [2024-kwi-25 16:39:27 +0200]:
> The xe_gt_sriov_pf_init_early() and xe_gt_sriov_pf_init_hw() are
> ideal places to call per-GT PF service init and update functions.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_sriov_pf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf.c
> index 687ea81931d1..7decf71c2b7d 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf.c
> @@ -9,6 +9,7 @@
>
> #include "xe_gt_sriov_pf.h"
> #include "xe_gt_sriov_pf_helpers.h"
> +#include "xe_gt_sriov_pf_service.h"
> #include "xe_mmio.h"
>
> /*
> @@ -51,6 +52,10 @@ int xe_gt_sriov_pf_init_early(struct xe_gt *gt)
> if (err)
> return err;
>
> + err = xe_gt_sriov_pf_service_init(gt);
> + if (err)
> + return err;
> +
> return 0;
> }
>
> @@ -74,4 +79,6 @@ void xe_gt_sriov_pf_init_hw(struct xe_gt *gt)
> {
> if (pf_needs_enable_ggtt_guest_update(gt_to_xe(gt)))
> pf_enable_ggtt_guest_update(gt);
> +
> + xe_gt_sriov_pf_service_update(gt);
> }
LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> --
> 2.43.0
>
--
next prev parent reply other threads:[~2024-04-26 9:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 14:39 [PATCH 1/2] drm/xe/pf: Re-initialize SR-IOV specific HW settings Michal Wajdeczko
2024-04-25 14:39 ` [PATCH 2/2] drm/xe/pf: Initialize and update PF services on driver init Michal Wajdeczko
2024-04-26 9:17 ` Piotr Piórkowski [this message]
2024-04-25 14:45 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe/pf: Re-initialize SR-IOV specific HW settings Patchwork
2024-04-25 14:45 ` ✓ CI.checkpatch: " Patchwork
2024-04-25 14:46 ` ✓ CI.KUnit: " Patchwork
2024-04-25 14:58 ` ✓ CI.Build: " Patchwork
2024-04-25 15:03 ` ✗ CI.Hooks: failure " Patchwork
2024-04-25 15:04 ` ✗ CI.checksparse: warning " Patchwork
2024-04-25 15:39 ` ✓ CI.BAT: success " Patchwork
2024-04-26 5:49 ` ✓ CI.FULL: " Patchwork
2024-04-26 9:15 ` [PATCH 1/2] " Piotr Piórkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426091715.zhkclnw5lzn2xbs5@intel.com \
--to=piotr.piorkowski@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).