From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Francois Dugast <francois.dugast@intel.com>
Subject: Re: [PATCH 4/7] drm/xe: Relax runtime pm protection around VM
Date: Mon, 13 May 2024 15:23:38 +0200 [thread overview]
Message-ID: <19d7aa0852718b4ac5521c0048bacc5a11a137cc.camel@linux.intel.com> (raw)
In-Reply-To: <20240509191657.504300-4-rodrigo.vivi@intel.com>
On Thu, 2024-05-09 at 15:16 -0400, Rodrigo Vivi wrote:
> In the regular use case scenario, user space will create a
> VM, and keep it alive for the entire duration of its workload.
>
> For the regular desktop cases, it means that the VM
> is alive even on idle scenarios where display goes off. This
> is unacceptable since this would entirely block runtime PM
> indefinitely, blocking deeper Package-C state. This would be
> a waste drainage of power.
>
> Limit the VM protection solely for long-running workloads that
> are not protected by the scheduler references.
> By design, run_job for long-running workloads returns NULL and
> the scheduler drops all the references of it, hence protecting
> the VM for this case is necessary.
I still think we can drop the pm when we deactivate rebind and grab it
when we activate it. (vm->preeprt.rebind_deactivated) This will not
work for faulting vms though, and can be done as a follow-up if
desired.
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
> v2: Update commit message to a more imperative language and to
> reflect why the VM protection is really needed.
> Also add a comment in the code to let the reason visbible.
>
> v3: Remove vma_access case and the mentions to mmap. Mmap cases
> are already protected by the gem page fault.
>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Tested-by: Francois Dugast <francois.dugast@intel.com>
> Acked-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index c5b1694b292f..2a49dea231e7 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1347,7 +1347,13 @@ struct xe_vm *xe_vm_create(struct xe_device
> *xe, u32 flags)
>
> vm->pt_ops = &xelp_pt_ops;
>
> - if (!(flags & XE_VM_FLAG_MIGRATION))
> + /*
> + * Long-running workloads are not protected by the scheduler
> references.
> + * By design, run_job for long-running workloads returns
> NULL and the
> + * scheduler drops all the references of it, hence
> protecting the VM
> + * for this case is necessary.
> + */
> + if (flags & XE_VM_FLAG_LR_MODE)
> xe_pm_runtime_get_noresume(xe);
>
> vm_resv_obj = drm_gpuvm_resv_object_alloc(&xe->drm);
> @@ -1457,7 +1463,7 @@ struct xe_vm *xe_vm_create(struct xe_device
> *xe, u32 flags)
> for_each_tile(tile, xe, id)
> xe_range_fence_tree_fini(&vm->rftree[id]);
> kfree(vm);
> - if (!(flags & XE_VM_FLAG_MIGRATION))
> + if (flags & XE_VM_FLAG_LR_MODE)
> xe_pm_runtime_put(xe);
> return ERR_PTR(err);
> }
> @@ -1592,7 +1598,7 @@ static void vm_destroy_work_func(struct
> work_struct *w)
>
> mutex_destroy(&vm->snap_mutex);
>
> - if (!(vm->flags & XE_VM_FLAG_MIGRATION))
> + if (vm->flags & XE_VM_FLAG_LR_MODE)
> xe_pm_runtime_put(xe);
>
> for_each_tile(tile, xe, id)
next prev parent reply other threads:[~2024-05-13 13:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 19:16 [PATCH 1/7] drm/xe: Fix xe_pm_runtime_get_if_active return Rodrigo Vivi
2024-05-09 19:16 ` [PATCH 2/7] drm/xe: Fix xe_pm_runtime_get_if_in_use documentation Rodrigo Vivi
2024-05-09 19:16 ` [PATCH 3/7] drm/xe: Relax runtime pm protection during execution Rodrigo Vivi
2024-05-09 19:16 ` [PATCH 4/7] drm/xe: Relax runtime pm protection around VM Rodrigo Vivi
2024-05-09 19:28 ` Matthew Brost
2024-05-13 13:23 ` Thomas Hellström [this message]
2024-05-09 19:16 ` [PATCH 5/7] drm/xe: Prepare display for D3Cold Rodrigo Vivi
2024-05-09 19:16 ` [PATCH 6/7] drm/xe: Stop checking for power_lost on D3Cold Rodrigo Vivi
2024-05-10 4:23 ` Nilawar, Badal
2024-05-09 19:16 ` [PATCH 7/7] drm/xe: Enable D3Cold on 'low' VRAM utilization Rodrigo Vivi
2024-05-09 19:47 ` ✓ CI.Patch_applied: success for series starting with [1/7] drm/xe: Fix xe_pm_runtime_get_if_active return Patchwork
2024-05-09 19:47 ` ✓ CI.checkpatch: " Patchwork
2024-05-09 19:48 ` ✓ CI.KUnit: " Patchwork
2024-05-09 20:00 ` ✓ CI.Build: " Patchwork
2024-05-09 20:02 ` ✓ CI.Hooks: " Patchwork
2024-05-09 20:04 ` ✓ CI.checksparse: " Patchwork
2024-05-09 20:26 ` ✓ CI.BAT: " Patchwork
2024-05-10 0:49 ` ✗ CI.FULL: failure " Patchwork
2024-05-10 1:55 ` Rodrigo Vivi
2024-05-10 2:04 ` Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2024-05-08 20:07 [PATCH 1/7] " Rodrigo Vivi
2024-05-08 20:07 ` [PATCH 4/7] drm/xe: Relax runtime pm protection around VM Rodrigo Vivi
2024-05-09 15:48 ` Matthew Brost
2024-05-13 13:16 ` Thomas Hellström
2024-05-03 19:13 [PATCH 0/7] Unlock deeper package-C states (PC-10) and D3Cold Rodrigo Vivi
2024-05-03 19:13 ` [PATCH 4/7] drm/xe: Relax runtime pm protection around VM Rodrigo Vivi
2024-05-06 12:30 ` Thomas Hellström
2024-05-06 14:23 ` Rodrigo Vivi
2024-05-07 18:19 ` Matthew Brost
2024-05-09 11:48 ` Gupta, Anshuman
2024-05-09 19:41 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d7aa0852718b4ac5521c0048bacc5a11a137cc.camel@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).