From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Matthew Brost" <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: ✗ CI.checkpatch: warning for Convert multiple bind ops to 1 job (rev2)
Date: Wed, 15 May 2024 00:44:48 -0000 [thread overview]
Message-ID: <171573388842.2116540.6323460814636157713@8e613ede5ea5> (raw)
In-Reply-To: <20240515004010.100091-1-matthew.brost@intel.com>
== Series Details ==
Series: Convert multiple bind ops to 1 job (rev2)
URL : https://patchwork.freedesktop.org/series/133034/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
57b97a66dd129aea93991dc66cd10477f7a05cf8
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit f7d9f9971bc4cb1b718d662cf0508f20bc14ddcc
Author: Matthew Brost <matthew.brost@intel.com>
Date: Tue May 14 17:40:10 2024 -0700
drm/xe: Add VM bind IOCTL error injection
Add VM bind IOCTL error injection which steals MSB of the bind flags
field which if set injects errors at various points in the VM bind
IOCTL. Intended to validate error paths. Enabled by CONFIG_DRM_XE_DEBUG.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
+ /mt/dim checkpatch 4cb2d17202b74ed81c0b6f22e540d811458869df drm-intel
3a56e48610f5 drm/xe: s/xe_tile_migrate_engine/xe_tile_migrate_exec_queue
3240cf16b6e2 drm/xe: Add xe_vm_pgtable_update_op to xe_vma_ops
15c6214d947a drm/xe: Convert multiple bind ops into single job
-:13: WARNING:TYPO_SPELLING: 'implemenation' may be misspelled - perhaps 'implementation'?
#13:
The implemenation is roughly:
^^^^^^^^^^^^^
-:881: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#881: FILE: drivers/gpu/drm/xe/xe_pt.c:1162:
+ if (uvma->userptr.initial_bind && !xe_vm_in_fault_mode(vm))
+ return 0;
-:882: ERROR:CODE_INDENT: code indent should use tabs where possible
#882: FILE: drivers/gpu/drm/xe/xe_pt.c:1163:
+ return 0;$
-:882: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#882: FILE: drivers/gpu/drm/xe/xe_pt.c:1163:
+ return 0;$
-:1663: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1663: FILE: drivers/gpu/drm/xe/xe_pt.c:1897:
+ * installing job fence in various places.
+ *
-:1664: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1664: FILE: drivers/gpu/drm/xe/xe_pt.c:1898:
+ *
+ * Return: fence on success, negative ERR_PTR on error.
-:1796: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1796: FILE: drivers/gpu/drm/xe/xe_pt.c:2030:
+ }$
total: 1 errors, 6 warnings, 0 checks, 2524 lines checked
4c6cbd0fd7a9 drm/xe: Update VM trace events
2e82846680c6 drm/xe: Update PT layer with better error handling
f7d9f9971bc4 drm/xe: Add VM bind IOCTL error injection
-:99: ERROR:TRAILING_WHITESPACE: trailing whitespace
#99: FILE: drivers/gpu/drm/xe/xe_vm.c:2718:
+^I DRM_XE_VM_BIND_FLAG_DUMPABLE) $
total: 1 errors, 0 warnings, 0 checks, 121 lines checked
next prev parent reply other threads:[~2024-05-15 0:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 0:40 [PATCH v2 0/6] Convert multiple bind ops to 1 job Matthew Brost
2024-05-15 0:40 ` [PATCH v2 1/6] drm/xe: s/xe_tile_migrate_engine/xe_tile_migrate_exec_queue Matthew Brost
2024-05-15 20:56 ` Cavitt, Jonathan
2024-05-18 2:42 ` Zeng, Oak
2024-05-15 0:40 ` [PATCH v2 2/6] drm/xe: Add xe_vm_pgtable_update_op to xe_vma_ops Matthew Brost
2024-05-15 21:56 ` Cavitt, Jonathan
2024-05-15 0:40 ` [PATCH v2 3/6] drm/xe: Convert multiple bind ops into single job Matthew Brost
2024-05-15 0:40 ` [PATCH v2 4/6] drm/xe: Update VM trace events Matthew Brost
2024-05-15 20:59 ` Cavitt, Jonathan
2024-05-15 0:40 ` [PATCH v2 5/6] drm/xe: Update PT layer with better error handling Matthew Brost
2024-05-15 0:40 ` [PATCH v2 6/6] drm/xe: Add VM bind IOCTL error injection Matthew Brost
2024-05-15 21:29 ` Cavitt, Jonathan
2024-05-15 22:45 ` Matthew Brost
2024-05-15 0:44 ` ✓ CI.Patch_applied: success for Convert multiple bind ops to 1 job (rev2) Patchwork
2024-05-15 0:44 ` Patchwork [this message]
2024-05-15 0:45 ` ✓ CI.KUnit: " Patchwork
2024-05-15 0:57 ` ✓ CI.Build: " Patchwork
2024-05-15 0:59 ` ✓ CI.Hooks: " Patchwork
2024-05-15 1:01 ` ✓ CI.checksparse: " Patchwork
2024-05-15 1:26 ` ✓ CI.BAT: " Patchwork
2024-05-15 2:53 ` ✗ CI.FULL: failure " Patchwork
2024-05-18 2:41 ` [PATCH v2 0/6] Convert multiple bind ops to 1 job Zeng, Oak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171573388842.2116540.6323460814636157713@8e613ede5ea5 \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).