From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-xe@lists.freedesktop.org,
Francois Dugast <francois.dugast@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH] drm/xe/gt: Fix assert in L3 bank mask generation
Date: Thu, 2 May 2024 11:49:49 -0700 [thread overview]
Message-ID: <171467575246.3963368.3838097486966806440.b4-ty@intel.com> (raw)
In-Reply-To: <20240502124311.159695-1-francois.dugast@intel.com>
On Thu, 02 May 2024 14:43:10 +0200, Francois Dugast wrote:
> What needs to be asserted is that the pattern fits in the number
> of bits provided by the user in patternbits, otherwise it would
> be truncated when replicated according to the mask, which is
> likely not the intended use of this function.
> The pattern argument is a bitmap so use find_last_bit() instead
> of fls(). The bit position starts at index 0 so remove "or equal"
> from the comparison. XE_MAX_L3_BANK_MASK_BITS would be the
> returned value if the pattern is 0, which can be the case on some
> platforms.
>
> [...]
Applied to drm-xe-next, thanks!
[1/1] drm/xe/gt: Fix assert in L3 bank mask generation
commit: 8ad0e1810bf23f22cedb8a2664548b15646570c7
Best regards,
--
Lucas De Marchi <lucas.demarchi@intel.com>
next prev parent reply other threads:[~2024-05-02 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 12:43 [PATCH] drm/xe/gt: Fix assert in L3 bank mask generation Francois Dugast
2024-05-02 13:43 ` ✓ CI.Patch_applied: success for drm/xe/gt: Fix assert in L3 bank mask generation (rev4) Patchwork
2024-05-02 13:44 ` ✓ CI.checkpatch: " Patchwork
2024-05-02 13:52 ` ✓ CI.KUnit: " Patchwork
2024-05-02 14:04 ` ✓ CI.Build: " Patchwork
2024-05-02 14:06 ` ✓ CI.Hooks: " Patchwork
2024-05-02 14:08 ` ✓ CI.checksparse: " Patchwork
2024-05-02 14:51 ` ✓ CI.BAT: " Patchwork
2024-05-02 16:09 ` ✗ CI.FULL: failure " Patchwork
2024-05-02 18:49 ` Lucas De Marchi [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-30 8:43 [PATCH] drm/xe/gt: Fix assert in L3 bank mask generation Francois Dugast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171467575246.3963368.3838097486966806440.b4-ty@intel.com \
--to=lucas.demarchi@intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).