From: Thinh Tran <thinhtr@linux.ibm.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
netdev@vger.kernel.org, kuba@kernel.org,
anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com
Cc: edumazet@google.com, Robert Thomas <rob.thomas@ibm.com>,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix repeated EEH reports in MSI domain
Date: Mon, 6 May 2024 16:22:04 -0500 [thread overview]
Message-ID: <adba0c7b-bef4-4fff-9ff2-b56f8b122ab8@linux.ibm.com> (raw)
In-Reply-To: <c47dc55f-9ef7-4a18-8419-fca4afb605b0@intel.com>
On 5/6/2024 4:35 AM, Przemek Kitszel wrote:
> In general do not add a blank line after Fixes tag.
> Someone could complain that i40e driver had a bug prior to the cited
> core commit, but for more practical purposes I find it good as is.
> When you are a sender of the patch, it's good to place your Signed-off
> as a last tag.
>
> I appreciate your effort to minimize changed lines to have a fix better
> visible, however we avoid forward declarations in .c files.
> I would split this into two commits - the first to just factor out/move
> functions w/o functional changes, then second one with a logic fix.
>
Thanks for the review.
I'll correct the typos and resubmit with two separate commits .
Thinh Tran
prev parent reply other threads:[~2024-05-06 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 15:25 [Intel-wired-lan] [PATCH iwl-net] i40e: Fix repeated EEH reports in MSI domain Thinh Tran
2024-05-06 9:35 ` Przemek Kitszel
2024-05-06 21:22 ` Thinh Tran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adba0c7b-bef4-4fff-9ff2-b56f8b122ab8@linux.ibm.com \
--to=thinhtr@linux.ibm.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rob.thomas@ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).