From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: shayd@nvidia.com, maciej.fijalkowski@intel.com,
mateusz.polchlopek@intel.com, netdev@vger.kernel.org,
jiri@nvidia.com, michal.kubiak@intel.com,
intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com,
sridhar.samudrala@intel.com, jacob.e.keller@intel.com,
wojciech.drewek@intel.com, przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [iwl-next v1 3/4] ice: move VSI configuration outside repr setup
Date: Mon, 6 May 2024 10:50:53 +0200 [thread overview]
Message-ID: <ZjiZ7Re63+aEtROE@mev-dev> (raw)
In-Reply-To: <7003fe5e-4bb9-8335-6d3f-9edab0aa3570@intel.com>
On Wed, Apr 24, 2024 at 02:08:11PM -0700, Tony Nguyen wrote:
>
>
> On 4/19/2024 10:13 AM, Michal Swiatkowski wrote:
>
> > +/**
> > + * ice_eswitch_cfg_vsi - configure VSI to work in slow-path
> > + * @vsi: VSI structure of representee
> > + * @mac: representee MAC
>
> Can you fix the kdoc for this?
>
> > drivers/net/ethernet/intel/ice/ice_eswitch.c:140: warning: No description
> found for return value of 'ice_eswitch_cfg_vsi'
>
> Thanks,
> Tony
>
I sent v2, sorry for late response, I was OOO.
Thanks,
Michal
> > + */
> > +int ice_eswitch_cfg_vsi(struct ice_vsi *vsi, const u8 *mac)
> > +{
> > + int err;
> > +
next prev parent reply other threads:[~2024-05-06 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 17:13 [Intel-wired-lan] [iwl-next v1 0/4] ice: prepare representor for SF support Michal Swiatkowski
2024-04-19 17:13 ` [Intel-wired-lan] [iwl-next v1 1/4] ice: store representor ID in bridge port Michal Swiatkowski
2024-04-19 17:13 ` [Intel-wired-lan] [iwl-next v1 2/4] ice: move devlink locking outside the port creation Michal Swiatkowski
2024-04-19 17:13 ` [Intel-wired-lan] [iwl-next v1 3/4] ice: move VSI configuration outside repr setup Michal Swiatkowski
2024-04-24 21:08 ` Tony Nguyen
2024-05-06 8:50 ` Michal Swiatkowski [this message]
2024-04-19 17:13 ` [Intel-wired-lan] [iwl-next v1 4/4] ice: update representor when VSI is ready Michal Swiatkowski
2024-04-22 13:02 ` [Intel-wired-lan] [iwl-next v1 0/4] ice: prepare representor for SF support Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjiZ7Re63+aEtROE@mev-dev \
--to=michal.swiatkowski@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=maciej.fijalkowski@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pio.raczynski@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayd@nvidia.com \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).