From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: maciej.fijalkowski@intel.com, sridhar.samudrala@intel.com,
netdev@vger.kernel.org, mateusz.polchlopek@intel.com,
przemyslaw.kitszel@intel.com, shayd@nvidia.com,
intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com,
jiri@nvidia.com, jacob.e.keller@intel.com,
wojciech.drewek@intel.com, michal.kubiak@intel.com
Subject: Re: [Intel-wired-lan] [iwl-next v1 00/14] ice: support devlink subfunction
Date: Fri, 10 May 2024 14:26:44 +0200 [thread overview]
Message-ID: <Zj4ShOiyrGQK8J6p@mev-dev> (raw)
In-Reply-To: <Zj4AYN4uDtL51G1P@nanopsycho.orion>
On Fri, May 10, 2024 at 01:09:20PM +0200, Jiri Pirko wrote:
> Fri, May 10, 2024 at 09:24:48AM CEST, michal.swiatkowski@linux.intel.com wrote:
> >On Thu, May 09, 2024 at 01:18:29PM +0200, Jiri Pirko wrote:
> >> Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkowski@linux.intel.com wrote:
> >> >Hi,
> >> >
> >> >Currently ice driver does not allow creating more than one networking
> >> >device per physical function. The only way to have more hardware backed
> >> >netdev is to use SR-IOV.
> >> >
> >> >Following patchset adds support for devlink port API. For each new
> >> >pcisf type port, driver allocates new VSI, configures all resources
> >> >needed, including dynamically MSIX vectors, program rules and registers
> >> >new netdev.
> >> >
> >> >This series supports only one Tx/Rx queue pair per subfunction.
> >> >
> >> >Example commands:
> >> >devlink port add pci/0000:31:00.1 flavour pcisf pfnum 1 sfnum 1000
> >> >devlink port function set pci/0000:31:00.1/1 hw_addr 00:00:00:00:03:14
> >> >devlink port function set pci/0000:31:00.1/1 state active
> >> >devlink port function del pci/0000:31:00.1/1
> >> >
> >> >Make the port representor and eswitch code generic to support
> >> >subfunction representor type.
> >> >
> >> >VSI configuration is slightly different between VF and SF. It needs to
> >> >be reflected in the code.
> >> >
> >> >Most recent previous patchset (not containing port representor for SF
> >> >support). [1]
> >> >
> >> >[1] https://lore.kernel.org/netdev/20240417142028.2171-1-michal.swiatkowski@linux.intel.com/
> >> >
> >>
> >>
> >> I don't understand howcome the patchset is v1, yet there are patches
> >> that came through multiple iterations alread. Changelog is missing
> >> completely :/
> >>
> >
> >What is wrong here? There is a link to previous patchset with whole
> >changlog and links to previous ones. I didn't add changlog here as it is
> >new patchset (partialy the same as from [1], because of that I added a
> >link). I can add the changlog from [1] if you want, but for me it can be
> >missleading.
>
> It's always good to see what you changed if you send modified patches.
> That's all.
>
I will paste previous changelog in next version so.
>
> >
> >>
> >> >Michal Swiatkowski (7):
> >> > ice: treat subfunction VSI the same as PF VSI
> >> > ice: create port representor for SF
> >> > ice: don't set target VSI for subfunction
> >> > ice: check if SF is ready in ethtool ops
> >> > ice: netdevice ops for SF representor
> >> > ice: support subfunction devlink Tx topology
> >> > ice: basic support for VLAN in subfunctions
> >> >
> >> >Piotr Raczynski (7):
> >> > ice: add new VSI type for subfunctions
> >> > ice: export ice ndo_ops functions
> >> > ice: add basic devlink subfunctions support
> >> > ice: allocate devlink for subfunction
> >> > ice: base subfunction aux driver
> >> > ice: implement netdev for subfunction
> >> > ice: allow to activate and deactivate subfunction
> >> >
> >> > drivers/net/ethernet/intel/ice/Makefile | 2 +
> >> > .../net/ethernet/intel/ice/devlink/devlink.c | 48 ++
> >> > .../net/ethernet/intel/ice/devlink/devlink.h | 1 +
> >> > .../ethernet/intel/ice/devlink/devlink_port.c | 516 ++++++++++++++++++
> >> > .../ethernet/intel/ice/devlink/devlink_port.h | 43 ++
> >> > drivers/net/ethernet/intel/ice/ice.h | 19 +-
> >> > drivers/net/ethernet/intel/ice/ice_base.c | 5 +-
> >> > drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 1 +
> >> > drivers/net/ethernet/intel/ice/ice_eswitch.c | 85 ++-
> >> > drivers/net/ethernet/intel/ice/ice_eswitch.h | 22 +-
> >> > drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +-
> >> > drivers/net/ethernet/intel/ice/ice_lib.c | 52 +-
> >> > drivers/net/ethernet/intel/ice/ice_lib.h | 3 +
> >> > drivers/net/ethernet/intel/ice/ice_main.c | 66 ++-
> >> > drivers/net/ethernet/intel/ice/ice_repr.c | 195 +++++--
> >> > drivers/net/ethernet/intel/ice/ice_repr.h | 22 +-
> >> > drivers/net/ethernet/intel/ice/ice_sf_eth.c | 329 +++++++++++
> >> > drivers/net/ethernet/intel/ice/ice_sf_eth.h | 33 ++
> >> > .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.c | 21 +
> >> > .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.h | 13 +
> >> > drivers/net/ethernet/intel/ice/ice_sriov.c | 4 +-
> >> > drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
> >> > drivers/net/ethernet/intel/ice/ice_type.h | 1 +
> >> > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 +-
> >> > .../net/ethernet/intel/ice/ice_vsi_vlan_ops.c | 4 +
> >> > drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +-
> >> > 26 files changed, 1362 insertions(+), 138 deletions(-)
> >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_eth.c
> >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_eth.h
> >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.c
> >> > create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.h
> >> >
> >> >--
> >> >2.42.0
> >> >
> >> >
prev parent reply other threads:[~2024-05-10 12:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 11:45 [Intel-wired-lan] [iwl-next v1 00/14] ice: support devlink subfunction Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 01/14] ice: add new VSI type for subfunctions Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 02/14] ice: export ice ndo_ops functions Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 03/14] ice: add basic devlink subfunctions support Michal Swiatkowski
2024-05-09 11:06 ` Jiri Pirko
2024-05-10 7:13 ` Michal Swiatkowski
2024-05-10 11:05 ` Jiri Pirko
2024-05-10 12:25 ` Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 04/14] ice: treat subfunction VSI the same as PF VSI Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 05/14] ice: allocate devlink for subfunction Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 06/14] ice: base subfunction aux driver Michal Swiatkowski
2024-05-09 11:13 ` Jiri Pirko
2024-05-10 7:20 ` Michal Swiatkowski
2024-05-10 11:06 ` Jiri Pirko
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 07/14] ice: implement netdev for subfunction Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 08/14] ice: create port representor for SF Michal Swiatkowski
2024-05-09 11:16 ` Jiri Pirko
2024-05-10 7:31 ` Michal Swiatkowski
2024-05-10 11:07 ` Jiri Pirko
2024-05-10 12:25 ` Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 09/14] ice: don't set target VSI for subfunction Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 10/14] ice: check if SF is ready in ethtool ops Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 11/14] ice: netdevice ops for SF representor Michal Swiatkowski
2024-05-09 11:17 ` Jiri Pirko
2024-05-10 7:25 ` Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 12/14] ice: support subfunction devlink Tx topology Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 13/14] ice: basic support for VLAN in subfunctions Michal Swiatkowski
2024-05-07 11:45 ` [Intel-wired-lan] [iwl-next v1 14/14] ice: allow to activate and deactivate subfunction Michal Swiatkowski
2024-05-09 11:36 ` Jiri Pirko
2024-05-10 7:33 ` Michal Swiatkowski
2024-05-10 11:08 ` Jiri Pirko
2024-05-09 11:18 ` [Intel-wired-lan] [iwl-next v1 00/14] ice: support devlink subfunction Jiri Pirko
2024-05-10 7:24 ` Michal Swiatkowski
2024-05-10 11:09 ` Jiri Pirko
2024-05-10 12:26 ` Michal Swiatkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj4ShOiyrGQK8J6p@mev-dev \
--to=michal.swiatkowski@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=maciej.fijalkowski@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pio.raczynski@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayd@nvidia.com \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).