From: Jiri Pirko <jiri@resnulli.us>
To: "Kwapulinski, Piotr" <piotr.kwapulinski@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Jagielski, Jedrzej" <jedrzej.jagielski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"horms@kernel.org" <horms@kernel.org>,
"Wyborny, Carolyn" <carolyn.wyborny@intel.com>,
"Glaza, Jan" <jan.glaza@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device
Date: Wed, 24 Apr 2024 16:40:59 +0200 [thread overview]
Message-ID: <ZikZ-5O9Ta1mkT1O@nanopsycho> (raw)
In-Reply-To: <DM6PR11MB46105E83E5597982F1EF02C9F3102@DM6PR11MB4610.namprd11.prod.outlook.com>
Wed, Apr 24, 2024 at 03:49:09PM CEST, piotr.kwapulinski@intel.com wrote:
>>>-----Original Message-----
>>>From: Jiri Pirko <jiri@resnulli.us>
>>>Sent: Monday, April 22, 2024 4:26 PM
>>>To: Kwapulinski, Piotr <piotr.kwapulinski@intel.com>
>>>Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; horms@kernel.org; Wyborny, Carolyn <carolyn.wyborny@intel.com>; Jagielski, Jedrzej <jedrzej.jagielski@intel.com>; Glaza, Jan <jan.glaza@intel.com>
>>>Subject: Re: [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device
>>>
>>>Mon, Apr 22, 2024 at 03:06:11PM CEST, piotr.kwapulinski@intel.com wrote:
>>>
>>>[...]
>>>
>>>
>>>>diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>>>b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>>>index 559b443..ea6df1e 100644
>>>>--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>>>+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>>>>@@ -1,5 +1,5 @@
>>>> /* SPDX-License-Identifier: GPL-2.0 */
>>>>-/* Copyright(c) 1999 - 2018 Intel Corporation. */
>>>>+/* Copyright(c) 1999 - 2024 Intel Corporation. */
>>>>
>>>> #ifndef _IXGBE_H_
>>>> #define _IXGBE_H_
>>>>@@ -20,6 +20,7 @@
>>>> #include "ixgbe_type.h"
>>>> #include "ixgbe_common.h"
>>>> #include "ixgbe_dcb.h"
>>>>+#include "ixgbe_e610.h"
>>>> #if IS_ENABLED(CONFIG_FCOE)
>>>> #define IXGBE_FCOE
>>>> #include "ixgbe_fcoe.h"
>>>>@@ -28,7 +29,6 @@
>>>> #include <linux/dca.h>
>>>> #endif
>>>> #include "ixgbe_ipsec.h"
>>>>-
>>>
>>>Leftover hunk?
>>Will do
>I think it's better eventually to remove this blank line. What do you think ?
Does not seem to be ralated to the patch. Whatever.
>Thanks
>Piotr
prev parent reply other threads:[~2024-04-24 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:06 [Intel-wired-lan] [PATCH iwl-next v4 0/5] ixgbe: Add support for Intel(R) E610 device Piotr Kwapulinski
2024-04-22 13:06 ` [Intel-wired-lan] [PATCH iwl-next v4 1/5] ixgbe: Add support for E610 FW Admin Command Interface Piotr Kwapulinski
2024-04-22 13:06 ` [Intel-wired-lan] [PATCH iwl-next v4 2/5] ixgbe: Add support for E610 device capabilities detection Piotr Kwapulinski
2024-04-22 13:06 ` [Intel-wired-lan] [PATCH iwl-next v4 3/5] ixgbe: Add link management support for E610 device Piotr Kwapulinski
2024-04-22 13:06 ` [Intel-wired-lan] [PATCH iwl-next v4 4/5] ixgbe: Add support for NVM handling in " Piotr Kwapulinski
2024-04-22 13:06 ` [Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management " Piotr Kwapulinski
2024-04-22 14:25 ` Jiri Pirko
2024-04-24 8:10 ` Kwapulinski, Piotr
2024-04-24 13:49 ` Kwapulinski, Piotr
2024-04-24 14:40 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZikZ-5O9Ta1mkT1O@nanopsycho \
--to=jiri@resnulli.us \
--cc=carolyn.wyborny@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.glaza@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.kwapulinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).