From: Jiri Pirko <jiri@resnulli.us>
To: Sergey Temerkhanov <sergey.temerkhanov@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming
Date: Tue, 23 Apr 2024 13:36:09 +0200 [thread overview]
Message-ID: <ZiedKc5wE2-3LlaM@nanopsycho> (raw)
In-Reply-To: <20240423091459.72216-1-sergey.temerkhanov@intel.com>
Tue, Apr 23, 2024 at 11:14:59AM CEST, sergey.temerkhanov@intel.com wrote:
>Include segment/domain number in the device name to distinguish
>between PCI devices located on different root complexes in
>multi-segment configurations. Naming is changed from
>ptp_<bus>_<slot>_clk<clock> to ptp_<domain>_<bus>_<slot>_clk<clock>
I don't understand why you need to encode pci properties of a parent
device into the auxiliary bus name. Could you please explain the
motivation? Why you need a bus instance per PF?
The rest of the auxbus registrators don't do this. Could you please
align? Just have one bus for ice driver and that's it.
>
>v1->v2
>Rebase on top of the latest changes
>
>Signed-off-by: Sergey Temerkhanov <sergey.temerkhanov@intel.com>
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>---
> drivers/net/ethernet/intel/ice/ice_ptp.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c
>index 402436b72322..744b102f7636 100644
>--- a/drivers/net/ethernet/intel/ice/ice_ptp.c
>+++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
>@@ -2993,8 +2993,9 @@ ice_ptp_auxbus_create_id_table(struct ice_pf *pf, const char *name)
> static int ice_ptp_register_auxbus_driver(struct ice_pf *pf)
> {
> struct auxiliary_driver *aux_driver;
>+ struct pci_dev *pdev = pf->pdev;
> struct ice_ptp *ptp;
>- char busdev[8] = {};
>+ char busdev[16] = {};
> struct device *dev;
> char *name;
> int err;
>@@ -3005,8 +3006,10 @@ static int ice_ptp_register_auxbus_driver(struct ice_pf *pf)
> INIT_LIST_HEAD(&ptp->ports_owner.ports);
> mutex_init(&ptp->ports_owner.lock);
> if (ice_is_e810(&pf->hw))
>- sprintf(busdev, "%u_%u_", pf->pdev->bus->number,
>- PCI_SLOT(pf->pdev->devfn));
>+ snprintf(busdev, sizeof(busdev), "%u_%u_%u_",
>+ pci_domain_nr(pdev->bus),
>+ pdev->bus->number,
>+ PCI_SLOT(pdev->devfn));
> name = devm_kasprintf(dev, GFP_KERNEL, "ptp_%sclk%u", busdev,
> ice_get_ptp_src_clock_index(&pf->hw));
> if (!name)
>@@ -3210,8 +3213,9 @@ static void ice_ptp_release_auxbus_device(struct device *dev)
> static int ice_ptp_create_auxbus_device(struct ice_pf *pf)
> {
> struct auxiliary_device *aux_dev;
>+ struct pci_dev *pdev = pf->pdev;
> struct ice_ptp *ptp;
>- char busdev[8] = {};
>+ char busdev[16] = {};
> struct device *dev;
> char *name;
> int err;
>@@ -3224,8 +3228,10 @@ static int ice_ptp_create_auxbus_device(struct ice_pf *pf)
> aux_dev = &ptp->port.aux_dev;
>
> if (ice_is_e810(&pf->hw))
>- sprintf(busdev, "%u_%u_", pf->pdev->bus->number,
>- PCI_SLOT(pf->pdev->devfn));
>+ snprintf(busdev, sizeof(busdev), "%u_%u_%u_",
>+ pci_domain_nr(pdev->bus),
>+ pdev->bus->number,
>+ PCI_SLOT(pdev->devfn));
>
> name = devm_kasprintf(dev, GFP_KERNEL, "ptp_%sclk%u", busdev,
> ice_get_ptp_src_clock_index(&pf->hw));
>--
>2.35.3
>
>
next prev parent reply other threads:[~2024-04-23 11:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 9:14 [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming Sergey Temerkhanov
2024-04-23 11:36 ` Jiri Pirko [this message]
2024-04-23 11:56 ` Temerkhanov, Sergey
2024-04-23 13:14 ` Jiri Pirko
2024-04-23 22:03 ` Jacob Keller
2024-04-24 15:07 ` Jiri Pirko
2024-04-24 16:56 ` Jacob Keller
2024-04-26 11:19 ` Jiri Pirko
2024-04-26 12:49 ` Przemek Kitszel
2024-04-26 13:43 ` Jiri Pirko
2024-04-26 22:25 ` Jacob Keller
2024-04-29 11:55 ` Jiri Pirko
2024-04-29 22:28 ` [Intel-wired-lan] multi-function devices with global/cross-function interdependence (Was Re: [PATCH iwl-next v2] ice: Extend auxbus device naming) Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiedKc5wE2-3LlaM@nanopsycho \
--to=jiri@resnulli.us \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=sergey.temerkhanov@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).