From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@intel.com>
To: Marcin Szycik <marcin.szycik@linux.intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: Fix checking for unsupported keys on non-tunnel device
Date: Fri, 12 Apr 2024 06:45:27 +0000 [thread overview]
Message-ID: <PH0PR11MB5013DEDB3DA7637B39C9E0B796042@PH0PR11MB5013.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240409154543.8181-2-marcin.szycik@linux.intel.com>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Marcin Szycik
> Sent: Tuesday, April 9, 2024 9:16 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; Marcin Szycik <marcin.szycik@linux.intel.com>;
> Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix checking for unsupported
> keys on non-tunnel device
>
> Add missing FLOW_DISSECTOR_KEY_ENC_* checks to TC flower filter parsing.
> Without these checks, it would be possible to add filters with tunnel options
> on non-tunnel devices. enc_* options are only valid for tunnel devices.
>
> Example:
> devlink dev eswitch set $PF1_PCI mode switchdev
> echo 1 > /sys/class/net/$PF1/device/sriov_numvfs
> tc qdisc add dev $VF1_PR ingress
> ethtool -K $PF1 hw-tc-offload on
> tc filter add dev $VF1_PR ingress flower enc_ttl 12 skip_sw action drop
>
> Fixes: 9e300987d4a8 ("ice: VXLAN and Geneve TC support")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
prev parent reply other threads:[~2024-04-12 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 15:45 [Intel-wired-lan] [PATCH iwl-net] ice: Fix checking for unsupported keys on non-tunnel device Marcin Szycik
2024-04-10 0:05 ` Jacob Keller
2024-04-12 6:45 ` Buvaneswaran, Sujai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5013DEDB3DA7637B39C9E0B796042@PH0PR11MB5013.namprd11.prod.outlook.com \
--to=sujai.buvaneswaran@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).