From: "Singh, Krishneil K" <krishneil.k.singh@intel.com>
To: "Linga, Pavan Kumar" <pavan.kumar.linga@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "Tantilov, Emil S" <emil.s.tantilov@intel.com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"Hay, Joshua A" <joshua.a.hay@intel.com>,
"Daniele, Salvatore" <sdaniele@redhat.com>,
"Nemeth, Balazs" <bnemeth@redhat.com>,
"Linga, Pavan Kumar" <pavan.kumar.linga@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix kernel panic on unknown packet types
Date: Wed, 3 Apr 2024 18:23:31 +0000 [thread overview]
Message-ID: <MW4PR11MB59110AF513411DEA937896C0BA3D2@MW4PR11MB5911.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240321000925.14941-1-pavan.kumar.linga@intel.com>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Pavan Kumar Linga
> Sent: Wednesday, March 20, 2024 5:09 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Tantilov, Emil S <emil.s.tantilov@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; Hay, Joshua A <joshua.a.hay@intel.com>;
> Daniele, Salvatore <sdaniele@redhat.com>; Nemeth, Balazs
> <bnemeth@redhat.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: fix kernel panic on unknown
> packet types
>
> From: Joshua Hay <joshua.a.hay@intel.com>
>
> In the very rare case where a packet type is unknown to the driver,
> idpf_rx_process_skb_fields would return early without calling
> eth_type_trans to set the skb protocol / the network layer handler.
> This is especially problematic if tcpdump is running when such a
> packet is received, i.e. it would cause a kernel panic.
>
> Instead, call eth_type_trans for every single packet, even when
> the packet type is unknown.
>
> Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support")
> Reported-by: Balazs Nemeth <bnemeth@redhat.com>
> Signed-off-by: Joshua Hay <joshua.a.hay@intel.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Tested-by: Salvatore Daniele <sdaniele@redhat.com>
> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
> ---
> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index 2f8ad79ae3f0..017a081d8580 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
Tested-by: Krishneil Singh krishneil.k.singh@intel.com
prev parent reply other threads:[~2024-04-03 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 0:09 [Intel-wired-lan] [PATCH iwl-net] idpf: fix kernel panic on unknown packet types Pavan Kumar Linga
2024-04-03 18:23 ` Singh, Krishneil K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB59110AF513411DEA937896C0BA3D2@MW4PR11MB5911.namprd11.prod.outlook.com \
--to=krishneil.k.singh@intel.com \
--cc=bnemeth@redhat.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joshua.a.hay@intel.com \
--cc=pavan.kumar.linga@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdaniele@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).