From: "Kwapulinski, Piotr" <piotr.kwapulinski@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: "jiri@resnulli.us" <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Jagielski, Jedrzej" <jedrzej.jagielski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"horms@kernel.org" <horms@kernel.org>,
"Wyborny, Carolyn" <carolyn.wyborny@intel.com>,
"Glaza, Jan" <jan.glaza@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 5/5] ixgbe: Enable link management in E610 device
Date: Fri, 26 Apr 2024 11:36:15 +0000 [thread overview]
Message-ID: <DM6PR11MB4610C53C88941A7F8A1DB8EAF3162@DM6PR11MB4610.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1ad7d60c-ea33-43e4-9cc3-033786fce13b@molgen.mpg.de>
>-----Original Message-----
>From: Paul Menzel <pmenzel@molgen.mpg.de>
>Sent: Wednesday, April 24, 2024 4:53 PM
>To: Kwapulinski, Piotr <piotr.kwapulinski@intel.com>
>Cc: intel-wired-lan@lists.osuosl.org; jiri@resnulli.us; netdev@vger.kernel.org; Jagielski, Jedrzej <jedrzej.jagielski@intel.com>; horms@kernel.org; Wyborny, Carolyn <carolyn.wyborny@intel.com>; Glaza, Jan <jan.glaza@intel.com>
>Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 5/5] ixgbe: Enable link management in E610 device
>
>Dear Piotr,
>
>
>Thank you for the patch.
[...]
>> + unsigned int pool);
>> +void ixgbe_set_ethertype_anti_spoofing_x550(struct ixgbe_hw *hw,
>> + bool enable, int vf);
>> +
>> +#endif /* _IXGBE_X550_H_ */
>
>I know, it’s a lot of work to split out clean-up and formatting changes,
>but to save time for reviewers and make it easier, please try to do this
>right away in the future.
>
>
>Kind regards,
>
>Paul
Hello Paul,
Thank you for your review. I'll address your suggestions.
Best Regards
Piotr
next prev parent reply other threads:[~2024-04-26 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:22 [Intel-wired-lan] [PATCH iwl-next v5 0/5] ixgbe: Add support for Intel(R) E610 device Piotr Kwapulinski
2024-04-24 14:22 ` [Intel-wired-lan] [PATCH iwl-next v5 1/5] ixgbe: Add support for E610 FW Admin Command Interface Piotr Kwapulinski
2024-04-24 14:22 ` [Intel-wired-lan] [PATCH iwl-next v5 2/5] ixgbe: Add support for E610 device capabilities detection Piotr Kwapulinski
2024-04-24 14:22 ` [Intel-wired-lan] [PATCH iwl-next v5 3/5] ixgbe: Add link management support for E610 device Piotr Kwapulinski
2024-04-24 14:22 ` [Intel-wired-lan] [PATCH iwl-next v5 4/5] ixgbe: Add support for NVM handling in " Piotr Kwapulinski
2024-04-24 14:22 ` [Intel-wired-lan] [PATCH iwl-next v5 5/5] ixgbe: Enable link management " Piotr Kwapulinski
2024-04-24 14:52 ` Paul Menzel
2024-04-26 11:36 ` Kwapulinski, Piotr [this message]
2024-05-22 11:49 ` Kwapulinski, Piotr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4610C53C88941A7F8A1DB8EAF3162@DM6PR11MB4610.namprd11.prod.outlook.com \
--to=piotr.kwapulinski@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.glaza@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).