From: Ivan Vecera <ivecera@redhat.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
aleksandr.loktionov@intel.com, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 0/7] i40e: cleanups & refactors
Date: Fri, 26 Apr 2024 19:16:26 +0200 [thread overview]
Message-ID: <914424cb-d74a-40b3-95e4-03d17d653467@redhat.com> (raw)
In-Reply-To: <3bd08423-18cd-6e12-38ab-4d9656c9ecf1@intel.com>
On 12. 04. 24 23:19, Tony Nguyen wrote:
>
>
> On 3/27/2024 12:57 AM, Ivan Vecera wrote:
>> This series do following:
>> Patch 1 - Removes write-only flags field from i40e_veb structure and
>> from i40e_veb_setup() parameters
>> Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes()
>> and i40e_notify_client_of_netdev_close()
>> Patch 3 - Refactors parameter of i40e_detect_recover_hung()
>> Patch 4 - Adds helper i40e_pf_get_main_vsi() to get main VSI and uses it
>> in existing code
>> Patch 5 - Consolidates checks whether given VSI is the main one
>> Patch 6 - Adds helper i40e_pf_get_main_veb() to get main VEB and uses it
>> in existing code
>> Patch 7 - Adds helper i40e_vsi_reconfig_tc() to reconfigure TC for
>> particular and uses it to replace existing open-coded pieces
>
> Hi Ivan,
>
> With the new checks on kdoc [1], this now reports issues. Can you fix
> those? Feel free to send the new version to 'net-next' as our validation
> has finished their testing on this series.
>
> You can add my
>
> Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
>
> Thanks,
> Tony
Huh, I missed your email. Will send v3.
Thanks,
Ivan
>> Changes since v1:
>> - adjusted titles for patches 2 & 3
>>
>> Ivan Vecera (8):
>> i40e: Remove flags field from i40e_veb
>> i40e: Refactor argument of several client notification functions
>> i40e: Refactor argument of i40e_detect_recover_hung()
>> i40e: Add helper to access main VSI
>> i40e: Consolidate checks whether given VSI is main
>> i40e: Add helper to access main VEB
>> i40e: Add and use helper to reconfigure TC for given VSI
>>
>> drivers/net/ethernet/intel/i40e/i40e.h | 30 ++-
>> drivers/net/ethernet/intel/i40e/i40e_client.c | 28 +--
>> drivers/net/ethernet/intel/i40e/i40e_ddp.c | 3 +-
>> .../net/ethernet/intel/i40e/i40e_debugfs.c | 36 +--
>> .../net/ethernet/intel/i40e/i40e_ethtool.c | 29 ++-
>> drivers/net/ethernet/intel/i40e/i40e_main.c | 205 ++++++++++--------
>> drivers/net/ethernet/intel/i40e/i40e_ptp.c | 6 +-
>> .../net/ethernet/intel/i40e/i40e_register.h | 3 +
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 98 ++++++---
>> drivers/net/ethernet/intel/i40e/i40e_txrx.h | 3 +-
>> .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 14 +-
>> 11 files changed, 282 insertions(+), 173 deletions(-)
>
> [1] https://lore.kernel.org/netdev/20240411200608.2fcf7e36@kernel.org/
>
next prev parent reply other threads:[~2024-04-26 17:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 7:57 [Intel-wired-lan] [PATCH iwl-next v2 0/7] i40e: cleanups & refactors Ivan Vecera
2024-03-27 7:57 ` [Intel-wired-lan] [PATCH iwl-next v2 1/7] i40e: Remove flags field from i40e_veb Ivan Vecera
2024-03-28 17:23 ` Simon Horman
2024-04-02 4:20 ` Pucha, HimasekharX Reddy
2024-03-27 7:57 ` [Intel-wired-lan] [PATCH iwl-next v2 2/7] i40e: Refactor argument of several client notification functions Ivan Vecera
2024-03-28 17:22 ` Simon Horman
2024-03-27 7:57 ` [Intel-wired-lan] [PATCH iwl-next v2 3/7] i40e: Refactor argument of i40e_detect_recover_hung() Ivan Vecera
2024-03-28 17:23 ` Simon Horman
2024-03-29 4:47 ` Kalesh Anakkur Purayil
2024-03-29 11:02 ` Loktionov, Aleksandr
2024-04-02 4:21 ` Pucha, HimasekharX Reddy
2024-03-27 7:57 ` [Intel-wired-lan] [PATCH iwl-next v2 4/7] i40e: Add helper to access main VSI Ivan Vecera
2024-03-28 17:24 ` Simon Horman
2024-04-02 4:23 ` Pucha, HimasekharX Reddy
2024-03-27 7:57 ` [Intel-wired-lan] [PATCH iwl-next v2 5/7] i40e: Consolidate checks whether given VSI is main Ivan Vecera
2024-03-28 17:24 ` Simon Horman
2024-04-02 4:25 ` Pucha, HimasekharX Reddy
2024-03-27 7:57 ` [Intel-wired-lan] [PATCH iwl-next v2 6/7] i40e: Add helper to access main VEB Ivan Vecera
2024-03-28 17:24 ` Simon Horman
2024-04-02 4:33 ` Pucha, HimasekharX Reddy
2024-03-27 7:57 ` [Intel-wired-lan] [PATCH iwl-next v2 7/7] i40e: Add and use helper to reconfigure TC for given VSI Ivan Vecera
2024-03-28 17:25 ` Simon Horman
2024-04-12 14:19 ` Pucha, HimasekharX Reddy
2024-04-12 21:19 ` [Intel-wired-lan] [PATCH iwl-next v2 0/7] i40e: cleanups & refactors Tony Nguyen
2024-04-26 17:16 ` Ivan Vecera [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-27 7:48 Ivan Vecera
2024-03-27 7:56 ` Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=914424cb-d74a-40b3-95e4-03d17d653467@redhat.com \
--to=ivecera@redhat.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).