From: Jacob Keller <jacob.e.keller@intel.com>
To: Thinh Tran <thinhtr@linux.ibm.com>, <netdev@vger.kernel.org>,
<kuba@kernel.org>, <anthony.l.nguyen@intel.com>,
<aleksandr.loktionov@intel.com>, <przemyslaw.kitszel@intel.com>,
<horms@kernel.org>
Cc: intel-wired-lan@lists.osuosl.org, edumazet@google.com,
pabeni@redhat.com, rob.thomas@ibm.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH iwl-net V3, 2/2] i40e: Fully suspend and resume IO operations in EEH case
Date: Tue, 14 May 2024 14:30:42 -0700 [thread overview]
Message-ID: <83bc01e5-12ab-4f0e-9e3e-323b0c147d63@intel.com> (raw)
In-Reply-To: <20240514202141.408-3-thinhtr@linux.ibm.com>
On 5/14/2024 1:21 PM, Thinh Tran wrote:
> When EEH events occurs, the callback functions in the i40e, which are
> managed by the EEH driver, will completely suspend and resume all IO
> operations.
>
> - In the PCI error detected callback, replaced i40e_prep_for_reset()
> with i40e_io_suspend(). The change is to fully suspend all I/O
> operations
> - In the PCI error slot reset callback, replaced pci_enable_device_mem()
> with pci_enable_device(). This change enables both I/O and memory of
> the device.
> - In the PCI error resume callback, replaced i40e_handle_reset_warning()
> with i40e_io_resume(). This change allows the system to resume I/O
> operations
>
> Fixes: a5f3d2c17b07 ("powerpc/pseries/pci: Add MSI domains")
> Tested-by: Robert Thomas <rob.thomas@ibm.com>
> Signed-off-by: Thinh Tran <thinhtr@linux.ibm.com>
> ---
Thanks for moving this info to the commit message.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
prev parent reply other threads:[~2024-05-14 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 20:21 [Intel-wired-lan] [PATCH iwl-net V3, 0/2] Fix repeated EEH reports in MSI domain Thinh Tran
2024-05-14 20:21 ` [Intel-wired-lan] [PATCH iwl-net V3, 1/2] i40e: fractoring out i40e_suspend/i40e_resume Thinh Tran
2024-05-14 21:30 ` Jacob Keller
2024-05-15 5:08 ` Paul Menzel
2024-05-15 13:41 ` Thinh Tran
2024-05-14 20:21 ` [Intel-wired-lan] [PATCH iwl-net V3, 2/2] i40e: Fully suspend and resume IO operations in EEH case Thinh Tran
2024-05-14 21:30 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bc01e5-12ab-4f0e-9e3e-323b0c147d63@intel.com \
--to=jacob.e.keller@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rob.thomas@ibm.com \
--cc=thinhtr@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).