From: Jacob Keller <jacob.e.keller@intel.com>
To: <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net V2, 0/2] Fix repeated EEH reports in MSI domain
Date: Tue, 14 May 2024 10:11:31 -0700 [thread overview]
Message-ID: <7dc92a69-0ccf-43de-a506-ca9ab6b1bc6f@intel.com> (raw)
In-Reply-To: <20240514095505.GZ2787@kernel.org>
On 5/14/2024 2:55 AM, Simon Horman wrote:
> On Mon, May 13, 2024 at 12:55:47PM -0500, Thinh Tran wrote:
>> The patch fixes an issue where repeated EEH reports with a single error
>> on the bus of Intel X710 4-port 10G Base-T adapter in the MSI domain
>> causes the device to be permanently disabled. It fully resets and
>> restarts the device when handling the PCI EEH error.
>>
>> Two new functions, i40e_io_suspend() and i40e_io_resume(), have been
>> introduced. These functions were factored out from the existing
>> i40e_suspend() and i40e_resume() respectively. This factoring was
>> done due to concerns about the logic of the I40E_SUSPENSED state, which
>> caused the device not able to recover. The functions are now used in the
>> EEH handling for device suspend/resume callbacks.
>>
>> - In the PCI error detected callback, replaced i40e_prep_for_reset()
>> with i40e_io_suspend(). The change is to fully suspend all I/O
>> operations
>> - In the PCI error slot reset callback, replaced pci_enable_device_mem()
>> with pci_enable_device(). This change enables both I/O and memory of
>> the device.
>> - In the PCI error resume callback, replaced i40e_handle_reset_warning()
>> with i40e_io_resume(). This change allows the system to resume I/O
>> operations
>>
>> v2: fixed typos and split into two commits
>
> Hi,
>
> These patches look good to me, but I think it would be worth adding parts
> of the text above to the commit messages of each patch. This will make the
> information easier to find in git logs in future.
>
Yes please, I'd like a reworded message as well so that we don't lose
this important context.
>>
>> Thinh Tran (2):
>> i40e: fractoring out i40e_suspend/i40e_resume
>> i40e: Fully suspend and resume IO operations in EEH case
>>
>> drivers/net/ethernet/intel/i40e/i40e_main.c | 257 +++++++++++---------
>> 1 file changed, 140 insertions(+), 117 deletions(-)
>>
>> --
>> 2.25.1
>>>>
next prev parent reply other threads:[~2024-05-14 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 17:55 [Intel-wired-lan] [PATCH iwl-net V2, 0/2] Fix repeated EEH reports in MSI domain Thinh Tran
2024-05-13 17:55 ` [Intel-wired-lan] [PATCH iwl-net V2, 1/2] i40e: fractoring out i40e_suspend/i40e_resume Thinh Tran
2024-05-13 17:55 ` [Intel-wired-lan] [PATCH iwl-net V2, 2/2] i40e: Fully suspend and resume IO operations in EEH case Thinh Tran
2024-05-14 9:55 ` [Intel-wired-lan] [PATCH iwl-net V2, 0/2] Fix repeated EEH reports in MSI domain Simon Horman
2024-05-14 17:11 ` Jacob Keller [this message]
2024-05-14 19:52 ` Thinh Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dc92a69-0ccf-43de-a506-ca9ab6b1bc6f@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).