From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Xu Du <xudu@redhat.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net] idpf: don't skip over ethtool tcp-data-split setting
Date: Wed, 15 May 2024 11:31:18 +0200 [thread overview]
Message-ID: <6d994163-abc3-4519-becd-b3813a43bf49@intel.com> (raw)
In-Reply-To: <20240515092414.158079-1-mschmidt@redhat.com>
From: Michal Schmidt <mschmidt@redhat.com>
Date: Wed, 15 May 2024 11:24:14 +0200
> Disabling tcp-data-split on idpf silently fails:
> # ethtool -G $NETDEV tcp-data-split off
> # ethtool -g $NETDEV | grep 'TCP data split'
> TCP data split: on
>
> But it works if you also change 'tx' or 'rx':
> # ethtool -G $NETDEV tcp-data-split off tx 256
> # ethtool -g $NETDEV | grep 'TCP data split'
> TCP data split: off
Oh crap >_< I'm sorry, thanks for the fix!
>
> The bug is in idpf_set_ringparam, where it takes a shortcut out if the
> TX and RX sizes are not changing. Fix it by checking also if the
> tcp-data-split setting remains unchanged. Only then can the soft reset
> be skipped.
>
> Fixes: 9b1aa3ef2328 ("idpf: add get/set for Ethtool's header split ringparam")
> Reported-by: Xu Du <xudu@redhat.com>
> Closes: https://issues.redhat.com/browse/RHEL-36182
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
> drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> index 986d429d1175..6972d728431c 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> @@ -376,7 +376,8 @@ static int idpf_set_ringparam(struct net_device *netdev,
> new_tx_count);
>
> if (new_tx_count == vport->txq_desc_count &&
> - new_rx_count == vport->rxq_desc_count)
> + new_rx_count == vport->rxq_desc_count &&
> + kring->tcp_data_split == idpf_vport_get_hsplit(vport))
> goto unlock_mutex;
>
> if (!idpf_vport_set_hsplit(vport, kring->tcp_data_split)) {
Olek
next prev parent reply other threads:[~2024-05-15 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 9:24 [Intel-wired-lan] [PATCH net] idpf: don't skip over ethtool tcp-data-split setting Michal Schmidt
2024-05-15 9:31 ` Alexander Lobakin [this message]
2024-05-17 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d994163-abc3-4519-becd-b3813a43bf49@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=xudu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).