From: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
To: Sunil Kovvuri Goutham <sgoutham@marvell.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
"horms@kernel.org" <horms@kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors
Date: Fri, 26 Apr 2024 09:15:37 +0200 [thread overview]
Message-ID: <3029ae3c-1c05-405f-a436-46b27498c6b1@intel.com> (raw)
In-Reply-To: <BY3PR18MB47378DFF0AF20BCDD99EC9F0C6112@BY3PR18MB4737.namprd18.prod.outlook.com>
On 4/23/2024 12:51 PM, Sunil Kovvuri Goutham wrote:
>
>
>> -----Original Message-----
>> From: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
>> Sent: Thursday, April 18, 2024 10:55 AM
>> To: intel-wired-lan@lists.osuosl.org
>> Cc: netdev@vger.kernel.org; horms@kernel.org; anthony.l.nguyen@intel.com;
>> Jacob Keller <jacob.e.keller@intel.com>; Wojciech Drewek
>> <wojciech.drewek@intel.com>; Mateusz Polchlopek
>> <mateusz.polchlopek@intel.com>
>> Subject: [EXTERNAL] [Intel-wired-lan] [PATCH iwl-next v5 09/12] iavf: refactor
>> iavf_clean_rx_irq to support legacy and flex descriptors
>>
>> From: Jacob Keller <jacob.e.keller@intel.com>
>>
>> Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
>> negotiating to enable the advanced flexible descriptor layout. Add the flexible
>> NIC layout (RXDID=2) as a member of the Rx descriptor union.
>>
>> Also add bit position definitions for the status and error indications that are
>> needed.
>>
>> The iavf_clean_rx_irq function needs to extract a few fields from the Rx
>> descriptor, including the size, rx_ptype, and vlan_tag.
>> Move the extraction to a separate function that decodes the fields into a
>> structure. This will reduce the burden for handling multiple descriptor types by
>> keeping the relevant extraction logic in one place.
>>
>> To support handling an additional descriptor format with minimal code
>> duplication, refactor Rx checksum handling so that the general logic is
>> separated from the bit calculations. Introduce an iavf_rx_desc_decoded
>> structure which holds the relevant bits decoded from the Rx descriptor.
>> This will enable implementing flexible descriptor handling without duplicating
>> the general logic twice.
>>
>> Introduce an iavf_extract_flex_rx_fields, iavf_flex_rx_hash, and
>> iavf_flex_rx_csum functions which operate on the flexible NIC descriptor
>> format instead of the legacy 32 byte format. Based on the negotiated RXDID,
>> select the correct function for processing the Rx descriptors.
>>
>> With this change, the Rx hot path should be functional when using either the
>> default legacy 32byte format or when we switch to the flexible NIC layout.
>>
>> Modify the Rx hot path to add support for the flexible descriptor format and
>> add request enabling Rx timestamps for all queues.
>>
>> As in ice, make sure we bump the checksum level if the hardware detected a
>> packet type which could have an outer checksum. This is important because
>> hardware only verifies the inner checksum.
>>
>
> What is the relevance of these csum related changes wrt introducing flex descriptor parsing
> for HW timestamps ?
>
> Thanks,
> Sunil.
Because of different types of descriptors we need to calculate csums in
slightly different way (based on the descriptor type). That's why we
have separated functions for both cases and enclosed common part in
another.
Did I answer Your question?
Thanks
Mateusz
next prev parent reply other threads:[~2024-04-26 7:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 5:24 [Intel-wired-lan] [PATCH iwl-next v5 00/12] Add support for Rx timestamping for both ice and iavf drivers Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 01/12] virtchnl: add support for enabling PTP on iAVF Mateusz Polchlopek
2024-04-18 18:49 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 02/12] ice: support Rx timestamp on flex descriptor Mateusz Polchlopek
2024-04-18 18:57 ` Rahul Rameshbabu
2024-04-22 9:34 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 03/12] virtchnl: add enumeration for the rxdid format Mateusz Polchlopek
2024-04-18 19:05 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 04/12] iavf: add support for negotiating flexible RXDID format Mateusz Polchlopek
2024-04-18 19:11 ` Rahul Rameshbabu
2024-04-22 9:34 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 05/12] iavf: negotiate PTP capabilities Mateusz Polchlopek
2024-04-18 19:16 ` Rahul Rameshbabu
2024-04-22 9:33 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 06/12] iavf: add initial framework for registering PTP clock Mateusz Polchlopek
2024-04-18 19:28 ` Rahul Rameshbabu
2024-04-22 9:29 ` Mateusz Polchlopek
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 07/12] iavf: add support for indirect access to PHC time Mateusz Polchlopek
2024-04-18 19:43 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 08/12] iavf: periodically cache " Mateusz Polchlopek
2024-04-18 19:51 ` Rahul Rameshbabu
2024-04-22 9:23 ` Mateusz Polchlopek
2024-04-24 22:03 ` Keller, Jacob E
2024-04-25 10:52 ` Przemek Kitszel
2024-04-25 16:28 ` Keller, Jacob E
2024-04-25 17:10 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors Mateusz Polchlopek
2024-04-18 20:00 ` Rahul Rameshbabu
2024-04-22 9:22 ` Mateusz Polchlopek
2024-04-23 10:51 ` Sunil Kovvuri Goutham
2024-04-26 7:15 ` Mateusz Polchlopek [this message]
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 10/12] iavf: Implement checking DD desc field Mateusz Polchlopek
2024-04-18 20:07 ` Rahul Rameshbabu
2024-04-18 5:24 ` [Intel-wired-lan] [PATCH iwl-next v5 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP Mateusz Polchlopek
2024-04-18 20:08 ` Rahul Rameshbabu
2024-04-18 5:25 ` [Intel-wired-lan] [PATCH iwl-next v5 12/12] iavf: add support for Rx timestamps to hotpath Mateusz Polchlopek
2024-04-18 20:12 ` Rahul Rameshbabu
2024-04-23 10:47 ` Sunil Kovvuri Goutham
2024-04-18 20:19 ` [Intel-wired-lan] [PATCH iwl-next v5 00/12] Add support for Rx timestamping for both ice and iavf drivers Rahul Rameshbabu
2024-04-22 9:37 ` Mateusz Polchlopek
2024-04-23 5:57 ` Rahul Rameshbabu
2024-04-23 6:08 ` Mateusz Polchlopek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3029ae3c-1c05-405f-a436-46b27498c6b1@intel.com \
--to=mateusz.polchlopek@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).