From: Bui Quang Minh <minhquangbui99@gmail.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
Rasesh Mody <rmody@marvell.com>,
Sudarsana Kalluru <skalluru@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Fabian Frederick <fabf@skynet.be>,
Saurav Kashyap <skashyap@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Nilesh Javali <nilesh.javali@cavium.com>,
Arun Easi <arun.easi@cavium.com>,
Manish Rangankar <manish.rangankar@cavium.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Sunil Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
hariprasad <hkelam@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Saurav Kashyap <saurav.kashyap@cavium.com>,
Bui Quang Minh <minhquangbui99@gmail.com>
Subject: [Intel-wired-lan] [PATCH v2 0/6] Ensure the copied buf is NUL terminated
Date: Wed, 24 Apr 2024 21:44:17 +0700 [thread overview]
Message-ID: <20240424-fix-oob-read-v2-0-f1f1b53a10f4@gmail.com> (raw)
Hi everyone,
I found that some drivers contains an out-of-bound read pattern like this
kern_buf = memdup_user(user_buf, count);
...
sscanf(kern_buf, ...);
The sscanf can be replaced by some other string-related functions. This
pattern can lead to out-of-bound read of kern_buf in string-related
functions.
This series fix the above issue by replacing memdup_user with
memdup_user_nul.
Thanks,
Quang Minh.
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
To: David S. Miller <davem@davemloft.net>
To: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
To: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
To: Rasesh Mody <rmody@marvell.com>
To: Sudarsana Kalluru <skalluru@marvell.com>
To: GR-Linux-NIC-Dev@marvell.com
To: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
To: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
To: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
To: Martin K. Petersen <martin.petersen@oracle.com>
To: Fabian Frederick <fabf@skynet.be>
To: Saurav Kashyap <skashyap@marvell.com>
To: GR-QLogic-Storage-Upstream@marvell.com
To: Nilesh Javali <nilesh.javali@cavium.com>
To: Arun Easi <arun.easi@cavium.com>
To: Manish Rangankar <manish.rangankar@cavium.com>
To: Vineeth Vijayan <vneethv@linux.ibm.com>
To: Peter Oberparleiter <oberpar@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>
To: Vasily Gorbik <gor@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Sven Schnelle <svens@linux.ibm.com>
To: Dupuis, Chad <chad.dupuis@cavium.com>
To: Sunil Goutham <sgoutham@marvell.com>
To: Linu Cherian <lcherian@marvell.com>
To: Geetha sowjanya <gakula@marvell.com>
To: Jerin Jacob <jerinj@marvell.com>
To: hariprasad <hkelam@marvell.com>
To: Subbaraya Sundeep <sbhatta@marvell.com>
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: Saurav Kashyap <saurav.kashyap@cavium.com>
Cc: linux-s390@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
Changes in v2:
- Patch 5: use memdup_user_nul instead
- Add patch 6
- Link to v1: https://lore.kernel.org/r/20240422-fix-oob-read-v1-0-e02854c30174@gmail.com
---
Bui Quang Minh (6):
ice: ensure the copied buf is NUL terminated
bna: ensure the copied buf is NUL terminated
bfa: ensure the copied buf is NUL terminated
qedf: ensure the copied buf is NUL terminated
cio: ensure the copied buf is NUL terminated
octeontx2-af: avoid off-by-one read from userspace
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 4 ++--
drivers/net/ethernet/intel/ice/ice_debugfs.c | 8 ++++----
drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 +---
drivers/s390/cio/cio_inject.c | 2 +-
drivers/scsi/bfa/bfad_debugfs.c | 4 ++--
drivers/scsi/qedf/qedf_debugfs.c | 2 +-
6 files changed, 11 insertions(+), 13 deletions(-)
---
base-commit: ed30a4a51bb196781c8058073ea720133a65596f
change-id: 20240422-fix-oob-read-19ae7f8f3711
Best regards,
--
Bui Quang Minh <minhquangbui99@gmail.com>
next reply other threads:[~2024-04-24 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:44 Bui Quang Minh [this message]
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 1/6] ice: ensure the copied buf is NUL terminated Bui Quang Minh
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 2/6] bna: " Bui Quang Minh
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 3/6] bfa: " Bui Quang Minh
2024-05-07 1:19 ` Martin K. Petersen
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 4/6] qedf: " Bui Quang Minh
2024-05-07 1:20 ` Martin K. Petersen
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 5/6] cio: " Bui Quang Minh
2024-04-24 14:54 ` Heiko Carstens
2024-04-24 15:16 ` Alexander Gordeev
2024-04-26 10:10 ` Alexander Gordeev
2024-04-26 14:29 ` Jakub Kicinski
2024-04-24 14:44 ` [Intel-wired-lan] [PATCH v2 6/6] octeontx2-af: avoid off-by-one read from userspace Bui Quang Minh
2024-04-26 2:30 ` [Intel-wired-lan] [PATCH v2 0/6] Ensure the copied buf is NUL terminated patchwork-bot+netdevbpf
2024-05-11 18:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424-fix-oob-read-v2-0-f1f1b53a10f4@gmail.com \
--to=minhquangbui99@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arun.easi@cavium.com \
--cc=axboe@kernel.dk \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabf@skynet.be \
--cc=gakula@marvell.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hkelam@marvell.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jerinj@marvell.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manish.rangankar@cavium.com \
--cc=martin.petersen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=nilesh.javali@cavium.com \
--cc=oberpar@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rmody@marvell.com \
--cc=saurav.kashyap@cavium.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=skalluru@marvell.com \
--cc=skashyap@marvell.com \
--cc=sudarsana.kalluru@qlogic.com \
--cc=svens@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).