Intel-GFX Archive mirror
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>, <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/intel/xe_gt_freq: Check for RPe freq updates
Date: Mon, 29 Apr 2024 08:44:34 -0400	[thread overview]
Message-ID: <Zi-WMuOQobaJ6GxQ@intel.com> (raw)
In-Reply-To: <20240425195657.3638599-1-vinay.belgaumkar@intel.com>

On Thu, Apr 25, 2024 at 12:56:57PM -0700, Vinay Belgaumkar wrote:
> Pcode can dynamically update RPe frequency. Use the latest value
> in tests that check it.
> 
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  tests/intel/xe_gt_freq.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> index c12f6c52c..5c6373016 100644
> --- a/tests/intel/xe_gt_freq.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -186,6 +186,9 @@ static void test_freq_fixed(int fd, int gt_id, bool gt_idle)
>  		igt_assert(get_freq(fd, gt_id, "act") == rpn);
>  	}
>  
> +	/* Refresh value of rpe, pcode could have adjusted it */
> +	rpe = get_freq(fd, gt_id, "rpe");
> +
>  	igt_assert(set_freq(fd, gt_id, "min", rpe) > 0);
>  	igt_assert(set_freq(fd, gt_id, "max", rpe) > 0);
>  	usleep(ACT_FREQ_LATENCY_US);
> @@ -268,6 +271,10 @@ static void test_freq_low_max(int fd, int gt_id)
>  	igt_assert(set_freq(fd, gt_id, "min", rpe) > 0);
>  	igt_assert(set_freq(fd, gt_id, "max", rpn) > 0);
>  	usleep(ACT_FREQ_LATENCY_US);
> +
> +	/* Refresh value of rpe, pcode could have adjusted it */
> +	rpe = get_freq(fd, gt_id, "rpe");
> +
>  	igt_assert(get_freq(fd, gt_id, "cur") == rpe);
>  
>  	if (!xe_is_gt_in_c6(fd, gt_id))
> -- 
> 2.38.1
> 

      reply	other threads:[~2024-04-29 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 19:56 [PATCH i-g-t] tests/intel/xe_gt_freq: Check for RPe freq updates Vinay Belgaumkar
2024-04-29 12:44 ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zi-WMuOQobaJ6GxQ@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).