Intel-GFX Archive mirror
 help / color / mirror / Atom feed
From: "Bhadane, Dnyaneshwar" <dnyaneshwar.bhadane@intel.com>
To: "Sousa, Gustavo" <gustavo.sousa@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: RE: [PATCH] drm/i915/bmg: Load DMC
Date: Mon, 13 May 2024 11:21:31 +0000	[thread overview]
Message-ID: <IA1PR11MB6266FB8BDE79B6F054E8DC2FE2E22@IA1PR11MB6266.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240510140532.112352-2-gustavo.sousa@intel.com>



> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of
> Gustavo Sousa
> Sent: Friday, May 10, 2024 7:36 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Subject: [PATCH] drm/i915/bmg: Load DMC
> 
> Load Battlemage's DMC. We re-use XELPDP_DMC_MAX_FW_SIZE since BMG's
> display is a derivative of Xe_LPD+ and has the same MMIO offset limits.
> 
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---

Some CI skips/failures are in the CI result and those are not related to this change.
LGTM. 
Reviewed-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

>  drivers/gpu/drm/i915/display/intel_dmc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> b/drivers/gpu/drm/i915/display/intel_dmc.c
> index cbd2ac5671b1..63fccdda56c0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -115,6 +115,9 @@ static bool dmc_firmware_param_disabled(struct
> drm_i915_private *i915)
>  #define XE2LPD_DMC_PATH			DMC_PATH(xe2lpd)
>  MODULE_FIRMWARE(XE2LPD_DMC_PATH);
> 
> +#define BMG_DMC_PATH			DMC_PATH(bmg)
> +MODULE_FIRMWARE(BMG_DMC_PATH);
> +
>  #define MTL_DMC_PATH			DMC_PATH(mtl)
>  MODULE_FIRMWARE(MTL_DMC_PATH);
> 
> @@ -166,6 +169,9 @@ static const char *dmc_firmware_default(struct
> drm_i915_private *i915, u32 *size
>  	if (DISPLAY_VER_FULL(i915) == IP_VER(20, 0)) {
>  		fw_path = XE2LPD_DMC_PATH;
>  		max_fw_size = XE2LPD_DMC_MAX_FW_SIZE;
> +	} else if (DISPLAY_VER_FULL(i915) == IP_VER(14, 1)) {
> +		fw_path = BMG_DMC_PATH;
> +		max_fw_size = XELPDP_DMC_MAX_FW_SIZE;
>  	} else if (DISPLAY_VER_FULL(i915) == IP_VER(14, 0)) {
>  		fw_path = MTL_DMC_PATH;
>  		max_fw_size = XELPDP_DMC_MAX_FW_SIZE;
> --
> 2.45.0


  parent reply	other threads:[~2024-05-13 11:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 14:05 [PATCH] drm/i915/bmg: Load DMC Gustavo Sousa
2024-05-10 14:42 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-05-11  7:21 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-13 11:21 ` Bhadane, Dnyaneshwar [this message]
2024-05-22 12:26   ` [PATCH] " Gustavo Sousa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IA1PR11MB6266FB8BDE79B6F054E8DC2FE2E22@IA1PR11MB6266.namprd11.prod.outlook.com \
    --to=dnyaneshwar.bhadane@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).