From: Jani Nikula <jani.nikula@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 17/19] drm/i915: pass dev_priv explicitly to ALPM_CTL2
Date: Mon, 06 May 2024 11:28:00 +0300 [thread overview]
Message-ID: <87v83rny3z.fsf@intel.com> (raw)
In-Reply-To: <b25a29ac1fc9761f336e8b3793fae037c9f8388f.camel@intel.com>
On Mon, 06 May 2024, "Hogander, Jouni" <jouni.hogander@intel.com> wrote:
> On Thu, 2024-05-02 at 13:40 +0300, Jani Nikula wrote:
>> On Tue, 30 Apr 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> > On Tue, Apr 30, 2024 at 01:10:11PM +0300, Jani Nikula wrote:
>> > > Avoid the implicit dev_priv local variable use, and pass dev_priv
>> > > explicitly to the ALPM_CTL2 register macro.
>> > >
>> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> > > ---
>> > > drivers/gpu/drm/i915/display/intel_psr_regs.h | 2 +-
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h
>> > > b/drivers/gpu/drm/i915/display/intel_psr_regs.h
>> > > index 4d950b22d4f1..05dc1c1d4ac2 100644
>> > > --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h
>> > > +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h
>> > > @@ -321,7 +321,7 @@
>> > > #define
>> > > ALPM_CTL_AUX_LESS_WAKE_TIME(val) REG_FIELD_PREP(ALPM
>> > > _CTL_AUX_LESS_WAKE_TIME_MASK, val)
>> > >
>> > > #define _ALPM_CTL2_A 0x60954
>> > > -#define ALPM_CTL2(tran) _MMIO_TRANS2(dev_priv, tran,
>> > > _ALPM_CTL2_A)
>> > > +#define ALPM_CTL2(dev_priv, tran) _MMIO_TRANS2(dev_priv,
>> > > tran, _ALPM_CTL2_A)
>> >
>> > no usage? should we just delete it?
>>
>> I believe a recent addition to enable ALPM. Jouni?
>
> I added it together with other ALPM registers. Currently there is only
> one field for LunarLake and we are not changing it from the default. I
> would still keep it.
>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Thanks for all the reviews, pushed the lot to drm-intel-next.
BR,
Jani.
>
>
>>
>> BR,
>> Jani.
>>
>> >
>> > > #define
>> > > ALPM_CTL2_SWITCH_TO_ACTIVE_LATENCY_MASK REG_GENMASK
>> > > (28, 24)
>> > > #define
>> > > ALPM_CTL2_SWITCH_TO_ACTIVE_LATENCY(val) REG_FIELD_P
>> > > REP(ALPM_CTL2_SWITCH_TO_ACTIVE_LATENCY_MASK, val)
>> > > #define
>> > > ALPM_CTL2_AUX_LESS_WAKE_TIME_EXTENSION_MASK REG_GENMASK
>> > > (19, 16)
>> > > --
>> > > 2.39.2
>> > >
>>
>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-05-06 8:28 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 10:09 [PATCH 00/19] drm/i915/psr: implicit dev_priv removal Jani Nikula
2024-04-30 10:09 ` [PATCH 01/19] drm/i915: pass dev_priv explicitly to TRANS_EXITLINE Jani Nikula
2024-05-01 2:05 ` Rodrigo Vivi
2024-04-30 10:09 ` [PATCH 02/19] drm/i915: pass dev_priv explicitly to EDP_PSR_CTL Jani Nikula
2024-05-01 2:05 ` Rodrigo Vivi
2024-04-30 10:09 ` [PATCH 03/19] drm/i915: pass dev_priv explicitly to TRANS_PSR_IMR Jani Nikula
2024-05-01 2:14 ` Rodrigo Vivi
2024-04-30 10:09 ` [PATCH 04/19] drm/i915: pass dev_priv explicitly to TRANS_PSR_IIR Jani Nikula
2024-05-01 2:15 ` Rodrigo Vivi
2024-04-30 10:09 ` [PATCH 05/19] drm/i915: pass dev_priv explicitly to EDP_PSR_AUX_CTL Jani Nikula
2024-05-01 2:18 ` Rodrigo Vivi
2024-05-02 9:28 ` Jani Nikula
2024-05-02 12:56 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 06/19] drm/i915: pass dev_priv explicitly to EDP_PSR_AUX_DATA Jani Nikula
2024-05-01 2:18 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 07/19] drm/i915: pass dev_priv explicitly to EDP_PSR_STATUS Jani Nikula
2024-05-01 2:19 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 08/19] drm/i915: pass dev_priv explicitly to EDP_PSR_PERF_CNT Jani Nikula
2024-05-01 2:19 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 09/19] drm/i915: pass dev_priv explicitly to EDP_PSR_DEBUG Jani Nikula
2024-05-01 2:19 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 10/19] drm/i915: pass dev_priv explicitly to EDP_PSR2_CTL Jani Nikula
2024-05-01 2:20 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 11/19] drm/i915: pass dev_priv explicitly to PSR_EVENT Jani Nikula
2024-05-01 2:20 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 12/19] drm/i915: pass dev_priv explicitly to EDP_PSR2_STATUS Jani Nikula
2024-05-01 2:21 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 13/19] drm/i915: pass dev_priv explicitly to _PSR2_SU_STATUS Jani Nikula
2024-05-01 2:23 ` Rodrigo Vivi
2024-05-02 9:30 ` Jani Nikula
2024-05-02 10:39 ` [PATCH v2] drm/i915: pass dev_priv explicitly to PSR2_SU_STATUS Jani Nikula
2024-05-02 12:55 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 14/19] drm/i915: pass dev_priv explicitly to PSR2_MAN_TRK_CTL Jani Nikula
2024-05-01 2:23 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 15/19] drm/i915: pass dev_priv explicitly to PIPE_SRCSZ_ERLY_TPT Jani Nikula
2024-05-01 2:24 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 16/19] drm/i915: pass dev_priv explicitly to ALPM_CTL Jani Nikula
2024-05-01 2:24 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 17/19] drm/i915: pass dev_priv explicitly to ALPM_CTL2 Jani Nikula
2024-05-01 2:25 ` Rodrigo Vivi
2024-05-02 10:40 ` Jani Nikula
2024-05-06 7:34 ` Hogander, Jouni
2024-05-06 8:28 ` Jani Nikula [this message]
2024-04-30 10:10 ` [PATCH 18/19] drm/i915: pass dev_priv explicitly to PORT_ALPM_CTL Jani Nikula
2024-05-01 2:26 ` Rodrigo Vivi
2024-04-30 10:10 ` [PATCH 19/19] drm/i915: pass dev_priv explicitly to PORT_ALPM_LFPS_CTL Jani Nikula
2024-05-01 2:26 ` Rodrigo Vivi
2024-04-30 12:09 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: implicit dev_priv removal Patchwork
2024-04-30 12:09 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-30 12:16 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-30 16:31 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-02 11:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: implicit dev_priv removal (rev2) Patchwork
2024-05-02 11:40 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v83rny3z.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).