From: Jani Nikula <jani.nikula@intel.com>
To: Luca Coelho <luciano.coelho@intel.com>, intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, ville.syrjala@linux.intel.com,
gustavo.sousa@intel.com, james.ausmus@intel.com
Subject: Re: [PATCH v5] drm/i915: limit eDP MSO pipe only for display version 20 and below
Date: Thu, 18 Apr 2024 14:28:38 +0300 [thread overview]
Message-ID: <8734riyknt.fsf@intel.com> (raw)
In-Reply-To: <20240404091646.165309-1-luciano.coelho@intel.com>
On Thu, 04 Apr 2024, Luca Coelho <luciano.coelho@intel.com> wrote:
> The pipes that can be used for eDP MSO are limited to pipe A (and
> sometimes also pipe B) only for display version 20 and below.
>
> Modify the function that returns the pipe mask for eDP MSO so that
> these limitations only apply to version 20 and below, enabling all
> pipes otherwise.
Thanks for the patch, pushed to din.
BR,
Jani.
>
> Bspec: 68923
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: James Ausmus <james.ausmus@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>
> In v5:
> * fixed Ville's name's wrong charset, which prevented patchwork
> from picking this up.
>
> In v4:
> * actually go back to unrestricting only for > 20. I sent the
> wrong patch version in v3.
>
> In v3:
> * go back to unrestricing only for > 20, since the change for
> versions 14 to 20 should be tested separately;
> * simplify the if blocks [Ville].
>
> In v2:
> * allow pipes A and B from ver 14 to 20 [Gustavo]
>
> drivers/gpu/drm/i915/display/intel_ddi.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index a3d3d4942eb1..5d2863c43296 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2336,10 +2336,15 @@ static void intel_ddi_power_up_lanes(struct intel_encoder *encoder,
> }
> }
>
> -/* Splitter enable for eDP MSO is limited to certain pipes. */
> +/*
> + * Splitter enable for eDP MSO is limited to certain pipes, on certain
> + * platforms.
> + */
> static u8 intel_ddi_splitter_pipe_mask(struct drm_i915_private *i915)
> {
> - if (IS_ALDERLAKE_P(i915))
> + if (DISPLAY_VER(i915) > 20)
> + return ~0;
> + else if (IS_ALDERLAKE_P(i915))
> return BIT(PIPE_A) | BIT(PIPE_B);
> else
> return BIT(PIPE_A);
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-04-18 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 9:16 [PATCH v5] drm/i915: limit eDP MSO pipe only for display version 20 and below Luca Coelho
2024-04-04 17:04 ` ✗ Fi.CI.BAT: failure for drm/i915: limit eDP MSO pipe only for display version 20 and below (rev3) Patchwork
2024-04-16 9:54 ` ✗ Fi.CI.BAT: failure for drm/i915: limit eDP MSO pipe only for display version 20 and below (rev4) Patchwork
2024-04-17 7:19 ` Luca Coelho
2024-04-17 12:06 ` Illipilli, TejasreeX
2024-04-17 11:52 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-18 1:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-18 11:28 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734riyknt.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=james.ausmus@intel.com \
--cc=luciano.coelho@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).