From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: pass dev_priv explicitly to PORT_DFT2_G4X
Date: Wed, 08 May 2024 12:17:12 +0300 [thread overview]
Message-ID: <871q6cll2f.fsf@intel.com> (raw)
In-Reply-To: <ZjjJUO6_QRII3zrN@intel.com>
On Mon, 06 May 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, May 06, 2024 at 01:09:04PM +0300, Jani Nikula wrote:
>> Avoid the implicit dev_priv local variable use, and pass dev_priv
>> explicitly to the PORT_DFT2_G4X register macro.
>
> Looks like we only use this on VLV/CHV, so could define a fixed
> offset _VLV variant.
>
> But this works too
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Took the easy route and pushed them as-is, thanks for the review.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-05-08 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 10:09 [PATCH 0/3] drm/i915/display: remove implicit dev_priv from pipe crc Jani Nikula
2024-05-06 10:09 ` [PATCH 1/3] drm/i915: pass dev_priv explicitly to PIPE_CRC_CTL Jani Nikula
2024-05-06 12:14 ` Ville Syrjälä
2024-05-06 10:09 ` [PATCH 2/3] drm/i915: pass dev_priv explicitly to PIPE_CRC_* Jani Nikula
2024-05-06 12:13 ` Ville Syrjälä
2024-05-06 10:09 ` [PATCH 3/3] drm/i915: pass dev_priv explicitly to PORT_DFT2_G4X Jani Nikula
2024-05-06 12:13 ` Ville Syrjälä
2024-05-08 9:17 ` Jani Nikula [this message]
2024-05-06 10:57 ` ✓ Fi.CI.BAT: success for drm/i915/display: remove implicit dev_priv from pipe crc Patchwork
2024-05-06 13:59 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q6cll2f.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).