From: Julia Filipchuk <julia.filipchuk@intel.com>
To: Intel-GFX@Lists.FreeDesktop.Org
Cc: Arnd Bergmann <arnd@arndb.de>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
Julia Filipchuk <julia.filipchuk@intel.com>
Subject: [PATCH] drm/i915/guc: avoid FIELD_PREP warning
Date: Tue, 30 Apr 2024 09:48:09 -0700 [thread overview]
Message-ID: <20240430164809.482131-1-julia.filipchuk@intel.com> (raw)
From: Arnd Bergmann <arnd@arndb.de>
With gcc-7 and earlier, there are lots of warnings like
In file included from <command-line>:0:0:
In function '__guc_context_policy_add_priority.isra.66',
inlined from '__guc_context_set_prio.isra.67' at drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3292:3,
inlined from 'guc_context_set_prio' at drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3320:2:
include/linux/compiler_types.h:399:38: error: call to '__compiletime_assert_631' declared with attribute error: FIELD_PREP: mask is not constant
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^
...
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2422:3: note: in expansion of macro 'FIELD_PREP'
FIELD_PREP(GUC_KLV_0_KEY, GUC_CONTEXT_POLICIES_KLV_ID_##id) | \
^~~~~~~~~~
Make sure that GUC_KLV_0_KEY is an unsigned value to avoid the warning.
Fixes: 77b6f79df66e ("drm/i915/guc: Update to GuC version 69.0.3")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Julia Filipchuk <julia.filipchuk@intel.com>
---
Resubmit of a previous patch that was reviewed but never merged.
Patch resolves warnings on some older GCC versions of failed
constant propagation. Issue has been reported again; hoping to
resolve.
Previous Unmerged Patch:
https://patchwork.freedesktop.org/series/114145/
Reported Issue:
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10821
drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
index bebf28e3c479..525587cfe1af 100644
--- a/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
+++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h
@@ -29,9 +29,9 @@
*/
#define GUC_KLV_LEN_MIN 1u
-#define GUC_KLV_0_KEY (0xffff << 16)
-#define GUC_KLV_0_LEN (0xffff << 0)
-#define GUC_KLV_n_VALUE (0xffffffff << 0)
+#define GUC_KLV_0_KEY (0xffffu << 16)
+#define GUC_KLV_0_LEN (0xffffu << 0)
+#define GUC_KLV_n_VALUE (0xffffffffu << 0)
/**
* DOC: GuC Self Config KLVs
--
2.43.2
next reply other threads:[~2024-04-30 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 16:48 Julia Filipchuk [this message]
2024-04-30 18:15 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: avoid FIELD_PREP warning (rev2) Patchwork
2024-04-30 18:15 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-30 18:21 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-01 1:00 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430164809.482131-1-julia.filipchuk@intel.com \
--to=julia.filipchuk@intel.com \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=arnd@arndb.de \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).