From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: [PATCH 0/3] drm/i915/display: Unpin cursor worker in vblank worker series.
Date: Thu, 25 Apr 2024 12:26:01 +0200 [thread overview]
Message-ID: <20240425102604.1704520-1-maarten.lankhorst@linux.intel.com> (raw)
Use the vblank worker to unpin fb, for the legacy cursor fastpath and atomic cursor slowpath.
This prevents pipe fault errors from the cursor plane in Xe.
A small race appears to exist in kms_universal_plane@cursor-fb-leak on dg2, not sure why. I tried reproducing it and failed.
Maarten Lankhorst (2):
drm: Add drm_vblank_work_flush_all().
drm/i915: Use the same vblank worker for atomic unpin
Ville Syrjälä (1):
drm/i915: Use vblank worker to unpin old legacy cursor fb safely
drivers/gpu/drm/drm_vblank_work.c | 22 +++++++++++++
.../gpu/drm/i915/display/intel_atomic_plane.c | 13 +++++++-
.../gpu/drm/i915/display/intel_atomic_plane.h | 2 ++
drivers/gpu/drm/i915/display/intel_crtc.c | 31 +++++++++++++++++++
drivers/gpu/drm/i915/display/intel_cursor.c | 26 ++++++++++++++--
drivers/gpu/drm/i915/display/intel_cursor.h | 3 ++
drivers/gpu/drm/i915/display/intel_display.c | 3 ++
.../drm/i915/display/intel_display_types.h | 3 ++
include/drm/drm_vblank_work.h | 2 ++
9 files changed, 102 insertions(+), 3 deletions(-)
--
2.43.0
next reply other threads:[~2024-04-25 10:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 10:26 Maarten Lankhorst [this message]
2024-04-25 10:26 ` [PATCH 1/3] drm: Add drm_vblank_work_flush_all() Maarten Lankhorst
2024-04-25 10:26 ` [PATCH 2/3] drm/i915: Use vblank worker to unpin old legacy cursor fb safely Maarten Lankhorst
2024-04-25 10:26 ` [PATCH 3/3] drm/i915: Use the same vblank worker for atomic unpin Maarten Lankhorst
2024-04-25 11:11 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Unpin cursor worker in vblank worker series Patchwork
2024-04-25 11:11 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-25 11:17 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-25 16:01 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425102604.1704520-1-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).