From: tammo-v8BkjJTOJzf1qYPpFx2fzhvVK+yQ3ZXh@public.gmane.org
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [dracut] rd.shell won't work if "root=" is missing
Date: Tue, 5 Jan 2016 10:11:38 +0100 [thread overview]
Message-ID: <trinity-fb369bfb-8623-46c4-8628-71f8a6be4d9a-1451985097774@3capp-webde-bs44> (raw)
Hi,
Â
i just stumbled upon a detail in dracut that i found surprising and appears as a small bug to me.
If you boot a dracut image without giving a "root=" parameter (or e.g. a misspelled argument to that parameter) the system will _not_ drop you into a shell, even if rd.shell is set. IMHO this is not the expected behavior, as the manual says that rd.shell will drop you into a shell if rd.shell is set and no root is found. So i would suggest to change the "die()" function in the dracut-lib.sh and add a test for rd.shell in line 460 (getargbool 0 "rd.debug=" && emergency_shell) too. The system will already drop you in a shell if you have a "rd.debug" parameter set, but i think that rd.shell (and probably "rdshell" too) alone should be sufficient, as this is more convinient and less surprising.
I could prepare a patch, if you prefer that.
If this is not some kind of bug, you may call it a "wishlist item" and/or change the documentation accordingly.
kr
Tammo
next reply other threads:[~2016-01-05 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 9:11 tammo-v8BkjJTOJzf1qYPpFx2fzhvVK+yQ3ZXh [this message]
2016-04-15 10:04 ` [dracut] rd.shell won't work if "root=" is missing Harald Hoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-fb369bfb-8623-46c4-8628-71f8a6be4d9a-1451985097774@3capp-webde-bs44 \
--to=tammo-v8bkjjtojzf1qyppfx2fzhvvk+yq3zxh@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).